Display more information in WebUI Masters #16636

kaijchen · 2022-12-08T15:40:10Z

What changes are proposed in this pull request?

Add more information in WebUI Masters:

Start time.
Elected / Step-down time.
Last checkpoint time.
Number of journal entries since checkpoint.
Build version.

Add fields in meta master RPC:

RegisterMasterPOptions
- start time
- primacy change time
- version
- revision
MasterHeartbeatPOptions
- last checkpoint time
- journal entries since checkpoint

Add metrics keys:

Master process start time.
Last gain primacy time.
Last lose primacy time.

MasterInfo and WebUI pages are changed accordingly.

Why are the changes needed?

Make Masters tab in WebUI more informative.

Fix: #16709

Does this PR introduce any user facing changes?

Fixes #8765

maobaolong · 2022-12-09T00:43:47Z

core/common/src/main/java/alluxio/util/webui/UIMasterInfo.java

-/**
- * Displays information about a master in the UI.
- */
-public class UIMasterInfo {


Why you remove this class

This class is never used.

maobaolong

Do the change about Leader -> Primary to keep consistency.

core/server/master/src/main/java/alluxio/master/meta/DefaultMetaMaster.java

webui/master/src/store/masters/reducer.tsx

core/server/master/src/main/java/alluxio/master/meta/AlluxioMasterRestServiceHandler.java

This reverts commit 9b5db59.

…terMasterClient

maobaolong · 2022-12-14T10:53:45Z

@tcrain Would you please take another look at this PR? Thanks!

kaijchen · 2023-02-06T14:24:08Z

Hi @LuQQiu and @tieujason330, can you help review this PR?

kaijchen · 2023-02-21T07:26:41Z

Last checkpoint is shown after setting alluxio.master.journal.checkpoint.period.entries to 1000.

tieujason330

web ui changes LGTM

maobaolong

LGTM

JiamingMai

LGTM

jiacheliu3

Mostly LGTM with one comment, thanks for the work!

jiacheliu3 · 2023-02-27T06:52:42Z

core/server/master/src/main/java/alluxio/master/meta/AlluxioMasterRestServiceHandler.java

-      response.setLeaderMasterInfo(leaderMasterInfo);
-      return response;
-    }, Configuration.global());
+    Gauge lastCheckpointGauge = MetricsSystem.METRIC_REGISTRY.getGauges()


this MetricsSystem.METRIC_REGISTRY.getGauges() is a bit expensive, can you only get once?

Updated. WEBUI_OVERVIEW in this class also call getGauges() multiple times, but it's not related to this PR.

jiacheliu3

LGTM, thanks!

jiacheliu3 · 2023-02-28T16:25:13Z

alluxio-bot, merge this please

kaijchen · 2023-02-28T16:38:27Z

Thanks everyone for reviewing.

kaijchen · 2023-02-28T16:38:38Z

Thanks everyone for reviewing.

### What changes are proposed in this pull request? Add more information in WebUI Masters: 1. Start time. 2. Elected / Step-down time. 3. Last checkpoint time. 4. Number of journal entries since checkpoint. 5. Build version. Add fields in meta master RPC: 1. RegisterMasterPOptions * start time * primacy change time * version * revision 2. MasterHeartbeatPOptions * last checkpoint time * journal entries since checkpoint Add metrics keys: 1. Master process start time. 2. Last gain primacy time. 3. Last lose primacy time. `MasterInfo` and WebUI pages are changed accordingly. ### Why are the changes needed? Make Masters tab in WebUI more informative. Fix: Alluxio#16709 ### Does this PR introduce any user facing changes? <img width="1705" alt="WebUI Masters" src="https://user-images.githubusercontent.com/5821159/207555228-f79fc246-692d-459a-9282-413490f7ff00.png"> Fixes Alluxio#8765 pr-link: Alluxio#16636 change-id: cid-ce162c4a6b2341b974daaa8f0823791ed5c032b2

…n WebUI Masters Add more information in WebUI Masters: 1. Start time. 2. Elected / Step-down time. 3. Last checkpoint time. 4. Number of journal entries since checkpoint. 5. Build version. Add fields in meta master RPC: 1. RegisterMasterPOptions * start time * primacy change time * version * revision 2. MasterHeartbeatPOptions * last checkpoint time * journal entries since checkpoint Add metrics keys: 1. Master process start time. 2. Last gain primacy time. 3. Last lose primacy time. `MasterInfo` and WebUI pages are changed accordingly. Make Masters tab in WebUI more informative. Fix: Alluxio#16709 <img width="1705" alt="WebUI Masters" src="https://user-images.githubusercontent.com/5821159/207555228-f79fc246-692d-459a-9282-413490f7ff00.png"> Fixes Alluxio#8765 pr-link: Alluxio#16636 change-id: cid-ce162c4a6b2341b974daaa8f0823791ed5c032b2

kaijchen added 3 commits December 8, 2022 23:32

Add start time in master WebUI

c5d6a10

Add build version in master WebUI

bb3c90b

Remove redundant code

38edfa5

alluxio-bot assigned tcrain Dec 8, 2022

Improve webui test

5313533

maobaolong reviewed Dec 9, 2022

View reviewed changes

kaijchen added 6 commits December 9, 2022 10:58

fixup: add missing fields in MasterInfo#toString()

0798312

Add elected time of primary master in webui

c405e7d

Merge branch 'master' into improve-master-webui

264216e

Simplify UI text

16934f4

Add step-down time of standby masters in webui

427bcbd

Fix MasterInfoTest: avoid overload

ebe0b80

maobaolong requested changes Dec 13, 2022

View reviewed changes

kaijchen added 4 commits December 13, 2022 16:11

Reorder getter/setters

62cd0f4

Change leader to primary

9b5db59

Revert "Change leader to primary"

eea1fad

This reverts commit 9b5db59.

Fix mLosePrimacyTimeMs never updated

f8e2f64

kaijchen changed the title ~~Add start time and build version in master WebUI~~ Add start time, primacy change time and build version in master WebUI Dec 13, 2022

kaijchen added 2 commits December 13, 2022 19:16

Embed master start time and lose primacy time in RetryHandlingMetaMas…

3f0883a

…terMasterClient

Cleanup and refactor

b5a4611

kaijchen changed the title ~~Add start time, primacy change time and build version in master WebUI~~ Display more information in master WebUI Dec 13, 2022

fixup

c528c50

kaijchen changed the title ~~Display more information in master WebUI~~ Display more information in WebUI Masters Dec 13, 2022

kaijchen added 5 commits December 14, 2022 14:08

Empty initialMastersState

95d5467

Add journal and checkpoint info

2d7bfdc

Simplify "Journal Entries" column name

b8e55c7

Store last primacy change time in metrics

1fd213c

Add Master.StartTime in metrics

50c2ea4

add @OverRide and omit javadoc

90edd31

kaijchen requested a review from LuQQiu February 6, 2023 14:17

maobaolong requested a review from tieujason330 February 6, 2023 14:22

kaijchen requested review from maobaolong and LuQQiu and removed request for LuQQiu, tieujason330 and maobaolong February 17, 2023 12:11

Merge branch 'Alluxio:master' into improve-master-webui

dfac929

elega requested review from tieujason330 and elega February 21, 2023 09:26

tieujason330 approved these changes Feb 21, 2023

View reviewed changes

maobaolong approved these changes Feb 23, 2023

View reviewed changes

JiamingMai approved these changes Feb 27, 2023

View reviewed changes

jiacheliu3 requested changes Feb 27, 2023

View reviewed changes

Reuse result of METRIC_REGISTRY.getGauges

416ccf6

jiacheliu3 approved these changes Feb 28, 2023

View reviewed changes

alluxio-bot merged commit 8502fbf into Alluxio:master Feb 28, 2023

kaijchen deleted the improve-master-webui branch February 28, 2023 16:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Display more information in WebUI Masters #16636

Display more information in WebUI Masters #16636

kaijchen commented Dec 8, 2022 •

edited by LuQQiu

Loading

maobaolong Dec 9, 2022

kaijchen Dec 9, 2022

maobaolong left a comment

maobaolong commented Dec 14, 2022

kaijchen commented Feb 6, 2023

kaijchen commented Feb 21, 2023

tieujason330 left a comment

maobaolong left a comment

JiamingMai left a comment

jiacheliu3 left a comment

jiacheliu3 Feb 27, 2023

kaijchen Feb 27, 2023

jiacheliu3 left a comment

jiacheliu3 commented Feb 28, 2023

kaijchen commented Feb 28, 2023

kaijchen commented Feb 28, 2023

Display more information in WebUI Masters #16636

Display more information in WebUI Masters #16636

Conversation

kaijchen commented Dec 8, 2022 • edited by LuQQiu Loading

What changes are proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user facing changes?

maobaolong Dec 9, 2022

Choose a reason for hiding this comment

kaijchen Dec 9, 2022

Choose a reason for hiding this comment

maobaolong left a comment

Choose a reason for hiding this comment

maobaolong commented Dec 14, 2022

kaijchen commented Feb 6, 2023

kaijchen commented Feb 21, 2023

tieujason330 left a comment

Choose a reason for hiding this comment

maobaolong left a comment

Choose a reason for hiding this comment

JiamingMai left a comment

Choose a reason for hiding this comment

jiacheliu3 left a comment

Choose a reason for hiding this comment

jiacheliu3 Feb 27, 2023

Choose a reason for hiding this comment

kaijchen Feb 27, 2023

Choose a reason for hiding this comment

jiacheliu3 left a comment

Choose a reason for hiding this comment

jiacheliu3 commented Feb 28, 2023

kaijchen commented Feb 28, 2023

kaijchen commented Feb 28, 2023

kaijchen commented Dec 8, 2022 •

edited by LuQQiu

Loading