Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging to capture jobControlId #16780

Merged
merged 3 commits into from
Jan 18, 2023
Merged

Fix logging to capture jobControlId #16780

merged 3 commits into from
Jan 18, 2023

Conversation

deepak-shivamurthy
Copy link
Contributor

What changes are proposed in this pull request?

Alluxio/Community#643
Fix logging to capture jobControlId

Why are the changes needed?

this will help in getting jobControlId in the logs, and will help in getting status information about the job

Does this PR introduce any user facing changes?

its just log level changes

jja725
jja725 approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@jja725 jja725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@jja725
Copy link
Contributor

jja725 commented Jan 16, 2023

Please fix the style, you can get related information here https://docs.alluxio.io/os/user/edge/en/contributor/Code-Conventions.html

@HelloHorizon
Copy link
Contributor

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit 412e549 into Alluxio:master Jan 18, 2023
@Xenorith
Copy link
Contributor

alluxio-bot, cherry-pick this to branch-2.8 please

@alluxio-bot
Copy link
Contributor

Auto cherry-pick unsuccessful:
Failed to finish cmd "git cherry-pick 412e549"
stderr: <error: could not apply 412e549... Fix logging to capture jobControlId
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

stdout: <>
err: exit status 1

Xenorith pushed a commit to Xenorith/alluxio that referenced this pull request Jan 19, 2023
@deepak-shivamurthy @Xenorith
Fix logging to capture jobControlId
f9a0a24 
Alluxio/Community#643
Fix logging to capture jobControlId

this will help in getting jobControlId in the logs, and will help in
getting status information about the job

its just log level changes

pr-link: Alluxio#16780
change-id: cid-551cf01210bb24d39239199adeb398201f67c184
jja725 pushed a commit to jja725/alluxio that referenced this pull request Jan 27, 2023
@deepak-shivamurthy @jja725
Fix logging to capture jobControlId
51a0d0f 
### What changes are proposed in this pull request?

Alluxio/Community#643
Fix logging to capture jobControlId

### Why are the changes needed?

this will help in getting jobControlId in the logs, and will help in
getting status information about the job

### Does this PR introduce any user facing changes?

its just log level changes

pr-link: Alluxio#16780
change-id: cid-551cf01210bb24d39239199adeb398201f67c184
@LuQQiu LuQQiu added area-log Improve logging, includes audit log area-jobservice Alluxio Job Service labels Feb 4, 2023
Xenorith pushed a commit to Xenorith/alluxio that referenced this pull request Mar 17, 2023
@deepak-shivamurthy @Xenorith
Fix logging to capture jobControlId
136c8f1 
### What changes are proposed in this pull request?

Alluxio/Community#643
Fix logging to capture jobControlId

### Why are the changes needed?

this will help in getting jobControlId in the logs, and will help in
getting status information about the job

### Does this PR introduce any user facing changes?

its just log level changes

pr-link: Alluxio#16780
change-id: cid-551cf01210bb24d39239199adeb398201f67c184
@Xenorith Xenorith mentioned this pull request Mar 17, 2023
Merged
alluxio-bot pushed a commit that referenced this pull request Mar 17, 2023
@Xenorith
Fix logging to capture jobControlId
757d5c4 
Cherry-pick of existing commit.
orig-pr: #16780
orig-commit: 412e549
orig-commit-author: Deepak Shivamurthy <107634330+deepak-shivamurthy@users.noreply.github.com>

pr-link: #17104
change-id: cid-551cf01210bb24d39239199adeb398201f67c184
jiacheliu3 pushed a commit to jiacheliu3/alluxio that referenced this pull request May 15, 2023
@deepak-shivamurthy @jiacheliu3
Fix logging to capture jobControlId
7496bc7 
### What changes are proposed in this pull request?

Alluxio/Community#643
Fix logging to capture jobControlId

### Why are the changes needed?

this will help in getting jobControlId in the logs, and will help in
getting status information about the job

### Does this PR introduce any user facing changes?

its just log level changes

pr-link: Alluxio#16780
change-id: cid-551cf01210bb24d39239199adeb398201f67c184
jiacheliu3 pushed a commit to jiacheliu3/alluxio that referenced this pull request May 15, 2023
@deepak-shivamurthy @jiacheliu3
Fix logging to capture jobControlId
cbb7890 
### What changes are proposed in this pull request?

Alluxio/Community#643
Fix logging to capture jobControlId

### Why are the changes needed?

this will help in getting jobControlId in the logs, and will help in
getting status information about the job

### Does this PR introduce any user facing changes?

its just log level changes

pr-link: Alluxio#16780
change-id: cid-551cf01210bb24d39239199adeb398201f67c184
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jja725 jja725 jja725 approved these changes

Assignees

@rongrong rongrong

Labels
area-jobservice Alluxio Job Service area-log Improve logging, includes audit log
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@deepak-shivamurthy @jja725 @HelloHorizon @Xenorith @alluxio-bot @rongrong @LuQQiu