Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buildx support for build-docker.sh #16822

Merged

Conversation

JySongWithZhangCe
Copy link
Contributor

@JySongWithZhangCe JySongWithZhangCe commented Jan 27, 2023

What changes are proposed in this pull request?

Fix #16821

Developers can execute cross compare with build-docker.sh
etc.
./build-docker.sh buildx linux/arm64

Why are the changes needed?

Nope.

Does this PR introduce any user facing changes?

Nope, just for developers.

@JySongWithZhangCe
Copy link
Contributor Author

@beinan Would you like to take a look~Thanks♪(・ω・)ノ

Copy link
Contributor

@Xenorith Xenorith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in case others are using the same script, can we preserve backwards compatibility by setting the most common default value for build_mode and platform, such that if the script was called as before (ex. dev/scripts/build-docker.sh path/to/tarball) it will still operate as before?

@JySongWithZhangCe
Copy link
Contributor Author

in case others are using the same script, can we preserve backwards compatibility by setting the most common default value for build_mode and platform, such that if the script was called as before (ex. dev/scripts/build-docker.sh path/to/tarball) it will still operate as before?

Makes sense, I'll modify it

@JySongWithZhangCe
Copy link
Contributor Author

JySongWithZhangCe commented Jan 27, 2023

in case others are using the same script, can we preserve backwards compatibility by setting the most common default value for build_mode and platform, such that if the script was called as before (ex. dev/scripts/build-docker.sh path/to/tarball) it will still operate as before?

Before this PR, build-docker.sh does not support setting parameters, so there is no backward compatibility issue on parameters. After the second commit is modified, it will be consistent with the previous image tag without specifying buildx.

@Xenorith
Copy link
Contributor

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit 98dba4d into Alluxio:master Jan 30, 2023
jiacheliu3 pushed a commit to jiacheliu3/alluxio that referenced this pull request May 15, 2023
### What changes are proposed in this pull request?
Fix Alluxio#16821

Developers can execute cross compare with `build-docker.sh`
etc.
`./build-docker.sh buildx linux/arm64`

### Why are the changes needed?
Nope.

### Does this PR introduce any user facing changes?
Nope, just for developers.

pr-link: Alluxio#16822
change-id: cid-736afb945b565d6756fa671e257a67d1db5e408a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add buildx support for build-docker.sh
4 participants