Make light and heavy thread pool configurable for s3 proxy v2 #17082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR LGTM but need your input @lucyge2022 |
jja725
approved these changes
Mar 21, 2023
|
alluxio-bot, merge this please |
jiacheliu3
pushed a commit
to jiacheliu3/alluxio
that referenced
this pull request
May 18, 2023
### What changes are proposed in this pull request? Add properties to config s3 proxy v2 thread pool. for light pool: 1. `alluxio.proxy.s3.v2.async.light.pool.core.thread.number` ; 2. `alluxio.proxy.s3.v2.async.light.pool.maximum.thread.number`; 3. `alluxio.proxy.s3.v2.async.light.pool.queue.size`. for heavy pool: 1. `alluxio.proxy.s3.v2.async.heavy.pool.core.thread.number` ; 2. `alluxio.proxy.s3.v2.async.heavy.pool.maximum.thread.number`; 3. `alluxio.proxy.s3.v2.async.heavy.pool.queue.size`. ### Why are the changes needed? We config `alluxio.web.threads` as 1000, because our OPS has reached 2000. The default value of thread number is not big enough. pr-link: Alluxio#17082 change-id: cid-a89b016822a511619d23971118336a34cdf39328
jiacheliu3
pushed a commit
to jiacheliu3/alluxio
that referenced
this pull request
May 18, 2023
### What changes are proposed in this pull request? Add properties to config s3 proxy v2 thread pool. for light pool: 1. `alluxio.proxy.s3.v2.async.light.pool.core.thread.number` ; 2. `alluxio.proxy.s3.v2.async.light.pool.maximum.thread.number`; 3. `alluxio.proxy.s3.v2.async.light.pool.queue.size`. for heavy pool: 1. `alluxio.proxy.s3.v2.async.heavy.pool.core.thread.number` ; 2. `alluxio.proxy.s3.v2.async.heavy.pool.maximum.thread.number`; 3. `alluxio.proxy.s3.v2.async.heavy.pool.queue.size`. ### Why are the changes needed? We config `alluxio.web.threads` as 1000, because our OPS has reached 2000. The default value of thread number is not big enough. pr-link: Alluxio#17082 change-id: cid-a89b016822a511619d23971118336a34cdf39328
jiacheliu3
pushed a commit
to jiacheliu3/alluxio
that referenced
this pull request
May 19, 2023
### What changes are proposed in this pull request? Add properties to config s3 proxy v2 thread pool. for light pool: 1. `alluxio.proxy.s3.v2.async.light.pool.core.thread.number` ; 2. `alluxio.proxy.s3.v2.async.light.pool.maximum.thread.number`; 3. `alluxio.proxy.s3.v2.async.light.pool.queue.size`. for heavy pool: 1. `alluxio.proxy.s3.v2.async.heavy.pool.core.thread.number` ; 2. `alluxio.proxy.s3.v2.async.heavy.pool.maximum.thread.number`; 3. `alluxio.proxy.s3.v2.async.heavy.pool.queue.size`. ### Why are the changes needed? We config `alluxio.web.threads` as 1000, because our OPS has reached 2000. The default value of thread number is not big enough. pr-link: Alluxio#17082 change-id: cid-a89b016822a511619d23971118336a34cdf39328
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Add properties to config s3 proxy v2 thread pool.
for light pool:
alluxio.proxy.s3.v2.async.light.pool.core.thread.number;alluxio.proxy.s3.v2.async.light.pool.maximum.thread.number;alluxio.proxy.s3.v2.async.light.pool.queue.size.for heavy pool:
alluxio.proxy.s3.v2.async.heavy.pool.core.thread.number;alluxio.proxy.s3.v2.async.heavy.pool.maximum.thread.number;alluxio.proxy.s3.v2.async.heavy.pool.queue.size.Why are the changes needed?
We config
alluxio.web.threadsas 1000, because our OPS has reached 2000. The default value of thread number is not big enough.