Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fuse metadata cache outdated issue after chmod/chown #18524

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

secfree
Copy link
Contributor

@secfree secfree commented Feb 20, 2024

What changes are proposed in this pull request?

Fix fuse metadata cache outdated issue after chmod/chown

Why are the changes needed?

Fix #18523

Does this PR introduce any user facing changes?

No

@humengyu2012
Copy link
Contributor

I think there's a situation here that needs consideration: if the directory is large, caching it in the metadata cache would take a long time. Is it reasonable to completely invalidate the cache of the parent directory when modifications occur in the child nodes, or should we simply replace the corresponding child nodes in the list cache?

@humengyu2012
Copy link
Contributor

@jiacheliu3 can you take a look?

@secfree
Copy link
Contributor Author

secfree commented Mar 1, 2024

I think there's a situation here that needs consideration: if the directory is large, caching it in the metadata cache would take a long time. Is it reasonable to completely invalidate the cache of the parent directory when modifications occur in the child nodes, or should we simply replace the corresponding child nodes in the list cache?

@humengyu2012 thanks for your reply. Currently MetadataCachingFileSystem only syncs metadata from the cluster but not replace existing ones. So I just keep setAcl/setAttribute consistent with createFile/createDirectory/delete/rename here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alluxio-fuse metadata cache does not update after chmod/chown
2 participants