[SMALLFIX] Configuration refactor #5775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
|
Automated checks report:
All checks passed! |
apc999
reviewed
Jul 10, 2017
| @Rule | ||
| public TemporaryFolder mTestFolder = new TemporaryFolder(); | ||
|
|
||
| @Rule | ||
| public ConfigurationRule mConfigurationRule = new ConfigurationRule( | ||
| new ImmutableMap.Builder().put(PropertyKey.MASTER_MOUNT_TABLE_ROOT_UFS, TEST_PATH).build()); |
There was a problem hiding this comment.
can be simplified to new ConfigurationRule(PropertyKey.MASTER_MOUNT_TABLE_ROOT_UFS, TEST_PATH)
There was a problem hiding this comment.
Thanks, I didn't know about that constructor. What do you think of
public ConfigurationRule mConfigurationRule = new ConfigurationRule(new HashMap() {{
put(PropertyKey.MASTER_MOUNT_TABLE_ROOT_UFS, TEST_PATH);
}});instead? I like it since the key/value are on the same line and it's easy to add new configuration if necessary.
There was a problem hiding this comment.
does this require java 8+ to compile? if no, I am good with this approach
There was a problem hiding this comment.
it works in Java 7, it does the same thing as the 1-property constructor in ConfigurationRule
apc999
approved these changes
Jul 10, 2017
|
Merged build finished. Test FAILed. |
|
Test FAILed. Build result: FAILURE[...truncated 2581 lines...][JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/hdfs/pom.xml to org.alluxio/alluxio-core-client-hdfs/1.6.0-SNAPSHOT/alluxio-core-client-hdfs-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/hdfs/target/alluxio-core-client-hdfs-1.6.0-SNAPSHOT.jar to org.alluxio/alluxio-core-client-hdfs/1.6.0-SNAPSHOT/alluxio-core-client-hdfs-1.6.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/hdfs/target/alluxio-core-client-hdfs-1.6.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-client-hdfs/1.6.0-SNAPSHOT/alluxio-core-client-hdfs-1.6.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/hdfs/target/alluxio-core-client-hdfs-1.6.0-SNAPSHOT-tests.jar to org.alluxio/alluxio-core-client-hdfs/1.6.0-SNAPSHOT/alluxio-core-client-hdfs-1.6.0-SNAPSHOT-tests.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/common/pom.xml to org.alluxio/alluxio-keyvalue-common/1.6.0-SNAPSHOT/alluxio-keyvalue-common-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/fs/pom.xml to org.alluxio/alluxio-core-client-fs/1.6.0-SNAPSHOT/alluxio-core-client-fs-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/fs/target/alluxio-core-client-fs-1.6.0-SNAPSHOT.jar to org.alluxio/alluxio-core-client-fs/1.6.0-SNAPSHOT/alluxio-core-client-fs-1.6.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/fs/target/alluxio-core-client-fs-1.6.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-client-fs/1.6.0-SNAPSHOT/alluxio-core-client-fs-1.6.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/fs/target/alluxio-core-client-fs-1.6.0-SNAPSHOT-tests.jar to org.alluxio/alluxio-core-client-fs/1.6.0-SNAPSHOT/alluxio-core-client-fs-1.6.0-SNAPSHOT-tests.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/pom.xml to org.alluxio/alluxio-core-common/1.6.0-SNAPSHOT/alluxio-core-common-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/target/alluxio-core-common-1.6.0-SNAPSHOT.jar to org.alluxio/alluxio-core-common/1.6.0-SNAPSHOT/alluxio-core-common-1.6.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/target/alluxio-core-common-1.6.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-common/1.6.0-SNAPSHOT/alluxio-core-common-1.6.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/target/alluxio-core-common-1.6.0-SNAPSHOT-tests.jar to org.alluxio/alluxio-core-common/1.6.0-SNAPSHOT/alluxio-core-common-1.6.0-SNAPSHOT-tests.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/worker/pom.xml to org.alluxio/alluxio-core-server-worker/1.6.0-SNAPSHOT/alluxio-core-server-worker-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/dependency-reduced-pom.xml to org.alluxio/alluxio-underfs-glusterfs/1.6.0-SNAPSHOT/alluxio-underfs-glusterfs-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/target/alluxio-underfs-glusterfs-1.6.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-glusterfs/1.6.0-SNAPSHOT/alluxio-underfs-glusterfs-1.6.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/target/alluxio-underfs-glusterfs-1.6.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-glusterfs/1.6.0-SNAPSHOT/alluxio-underfs-glusterfs-1.6.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/pom.xml to org.alluxio/alluxio-core-client/1.6.0-SNAPSHOT/alluxio-core-client-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/pom.xml to org.alluxio/alluxio-examples/1.6.0-SNAPSHOT/alluxio-examples-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/pom.xml to org.alluxio/alluxio-core/1.6.0-SNAPSHOT/alluxio-core-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/proxy/pom.xml to org.alluxio/alluxio-core-server-proxy/1.6.0-SNAPSHOT/alluxio-core-server-proxy-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/shell/pom.xml to org.alluxio/alluxio-shell/1.6.0-SNAPSHOT/alluxio-shell-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/tests/pom.xml to org.alluxio/alluxio-tests/1.6.0-SNAPSHOT/alluxio-tests-1.6.0-SNAPSHOT.pomchannel stoppedTest FAILed. |
calvinjia
requested changes
Jul 10, 2017
| @Rule | ||
| public ConfigurationRule mConfigurationRule = new ConfigurationRule(new HashMap() {{ | ||
| put(PropertyKey.MASTER_MOUNT_TABLE_ROOT_UFS, TEST_PATH); | ||
| }}); |
There was a problem hiding this comment.
Are we using this constructor because the builder one would be too verbose for one entry?
There was a problem hiding this comment.
The builder one is unnecessarily verbose in general. It's easier to read these rules when the first line doesn't wrap.
|
Merged build finished. Test FAILed. |
|
Test FAILed. Build result: FAILURE[...truncated 2579 lines...][JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/hdfs/pom.xml to org.alluxio/alluxio-core-client-hdfs/1.6.0-SNAPSHOT/alluxio-core-client-hdfs-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/hdfs/target/alluxio-core-client-hdfs-1.6.0-SNAPSHOT.jar to org.alluxio/alluxio-core-client-hdfs/1.6.0-SNAPSHOT/alluxio-core-client-hdfs-1.6.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/hdfs/target/alluxio-core-client-hdfs-1.6.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-client-hdfs/1.6.0-SNAPSHOT/alluxio-core-client-hdfs-1.6.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/hdfs/target/alluxio-core-client-hdfs-1.6.0-SNAPSHOT-tests.jar to org.alluxio/alluxio-core-client-hdfs/1.6.0-SNAPSHOT/alluxio-core-client-hdfs-1.6.0-SNAPSHOT-tests.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/common/pom.xml to org.alluxio/alluxio-keyvalue-common/1.6.0-SNAPSHOT/alluxio-keyvalue-common-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/fs/pom.xml to org.alluxio/alluxio-core-client-fs/1.6.0-SNAPSHOT/alluxio-core-client-fs-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/fs/target/alluxio-core-client-fs-1.6.0-SNAPSHOT.jar to org.alluxio/alluxio-core-client-fs/1.6.0-SNAPSHOT/alluxio-core-client-fs-1.6.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/fs/target/alluxio-core-client-fs-1.6.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-client-fs/1.6.0-SNAPSHOT/alluxio-core-client-fs-1.6.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/fs/target/alluxio-core-client-fs-1.6.0-SNAPSHOT-tests.jar to org.alluxio/alluxio-core-client-fs/1.6.0-SNAPSHOT/alluxio-core-client-fs-1.6.0-SNAPSHOT-tests.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/pom.xml to org.alluxio/alluxio-core-common/1.6.0-SNAPSHOT/alluxio-core-common-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/target/alluxio-core-common-1.6.0-SNAPSHOT.jar to org.alluxio/alluxio-core-common/1.6.0-SNAPSHOT/alluxio-core-common-1.6.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/target/alluxio-core-common-1.6.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-common/1.6.0-SNAPSHOT/alluxio-core-common-1.6.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/target/alluxio-core-common-1.6.0-SNAPSHOT-tests.jar to org.alluxio/alluxio-core-common/1.6.0-SNAPSHOT/alluxio-core-common-1.6.0-SNAPSHOT-tests.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/worker/pom.xml to org.alluxio/alluxio-core-server-worker/1.6.0-SNAPSHOT/alluxio-core-server-worker-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/dependency-reduced-pom.xml to org.alluxio/alluxio-underfs-glusterfs/1.6.0-SNAPSHOT/alluxio-underfs-glusterfs-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/target/alluxio-underfs-glusterfs-1.6.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-glusterfs/1.6.0-SNAPSHOT/alluxio-underfs-glusterfs-1.6.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/target/alluxio-underfs-glusterfs-1.6.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-glusterfs/1.6.0-SNAPSHOT/alluxio-underfs-glusterfs-1.6.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/pom.xml to org.alluxio/alluxio-core-client/1.6.0-SNAPSHOT/alluxio-core-client-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/pom.xml to org.alluxio/alluxio-examples/1.6.0-SNAPSHOT/alluxio-examples-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/pom.xml to org.alluxio/alluxio-core/1.6.0-SNAPSHOT/alluxio-core-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/proxy/pom.xml to org.alluxio/alluxio-core-server-proxy/1.6.0-SNAPSHOT/alluxio-core-server-proxy-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/shell/pom.xml to org.alluxio/alluxio-shell/1.6.0-SNAPSHOT/alluxio-shell-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/tests/pom.xml to org.alluxio/alluxio-tests/1.6.0-SNAPSHOT/alluxio-tests-1.6.0-SNAPSHOT.pomchannel stoppedTest FAILed. |
|
Merged build finished. Test FAILed. |
|
Test FAILed. Failed Tests: 1org.alluxio:alluxio-tests: 1Test FAILed. |
calvinjia
approved these changes
Jul 10, 2017
|
Jenkins, test this please |
|
Merged build finished. Test FAILed. |
|
Test FAILed. Build result: FAILURE[...truncated 2580 lines...][JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/hdfs/pom.xml to org.alluxio/alluxio-core-client-hdfs/1.6.0-SNAPSHOT/alluxio-core-client-hdfs-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/hdfs/target/alluxio-core-client-hdfs-1.6.0-SNAPSHOT.jar to org.alluxio/alluxio-core-client-hdfs/1.6.0-SNAPSHOT/alluxio-core-client-hdfs-1.6.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/hdfs/target/alluxio-core-client-hdfs-1.6.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-client-hdfs/1.6.0-SNAPSHOT/alluxio-core-client-hdfs-1.6.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/hdfs/target/alluxio-core-client-hdfs-1.6.0-SNAPSHOT-tests.jar to org.alluxio/alluxio-core-client-hdfs/1.6.0-SNAPSHOT/alluxio-core-client-hdfs-1.6.0-SNAPSHOT-tests.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/common/pom.xml to org.alluxio/alluxio-keyvalue-common/1.6.0-SNAPSHOT/alluxio-keyvalue-common-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/fs/pom.xml to org.alluxio/alluxio-core-client-fs/1.6.0-SNAPSHOT/alluxio-core-client-fs-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/fs/target/alluxio-core-client-fs-1.6.0-SNAPSHOT.jar to org.alluxio/alluxio-core-client-fs/1.6.0-SNAPSHOT/alluxio-core-client-fs-1.6.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/fs/target/alluxio-core-client-fs-1.6.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-client-fs/1.6.0-SNAPSHOT/alluxio-core-client-fs-1.6.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/fs/target/alluxio-core-client-fs-1.6.0-SNAPSHOT-tests.jar to org.alluxio/alluxio-core-client-fs/1.6.0-SNAPSHOT/alluxio-core-client-fs-1.6.0-SNAPSHOT-tests.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/pom.xml to org.alluxio/alluxio-core-common/1.6.0-SNAPSHOT/alluxio-core-common-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/target/alluxio-core-common-1.6.0-SNAPSHOT.jar to org.alluxio/alluxio-core-common/1.6.0-SNAPSHOT/alluxio-core-common-1.6.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/target/alluxio-core-common-1.6.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-common/1.6.0-SNAPSHOT/alluxio-core-common-1.6.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/target/alluxio-core-common-1.6.0-SNAPSHOT-tests.jar to org.alluxio/alluxio-core-common/1.6.0-SNAPSHOT/alluxio-core-common-1.6.0-SNAPSHOT-tests.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/worker/pom.xml to org.alluxio/alluxio-core-server-worker/1.6.0-SNAPSHOT/alluxio-core-server-worker-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/dependency-reduced-pom.xml to org.alluxio/alluxio-underfs-glusterfs/1.6.0-SNAPSHOT/alluxio-underfs-glusterfs-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/target/alluxio-underfs-glusterfs-1.6.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-glusterfs/1.6.0-SNAPSHOT/alluxio-underfs-glusterfs-1.6.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/target/alluxio-underfs-glusterfs-1.6.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-glusterfs/1.6.0-SNAPSHOT/alluxio-underfs-glusterfs-1.6.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/pom.xml to org.alluxio/alluxio-core-client/1.6.0-SNAPSHOT/alluxio-core-client-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/pom.xml to org.alluxio/alluxio-examples/1.6.0-SNAPSHOT/alluxio-examples-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/pom.xml to org.alluxio/alluxio-core/1.6.0-SNAPSHOT/alluxio-core-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/proxy/pom.xml to org.alluxio/alluxio-core-server-proxy/1.6.0-SNAPSHOT/alluxio-core-server-proxy-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/shell/pom.xml to org.alluxio/alluxio-shell/1.6.0-SNAPSHOT/alluxio-shell-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/tests/pom.xml to org.alluxio/alluxio-tests/1.6.0-SNAPSHOT/alluxio-tests-1.6.0-SNAPSHOT.pomchannel stoppedTest FAILed. |
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.