[SMALLFIX] Fix LOG.warn without context #6924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apc999
force-pushed
the
branch-1.7-smallfix3
branch
from
365039d
to
661cc8f
Compare
|
Merged build finished. Test FAILed. |
1 similar comment
|
Merged build finished. Test FAILed. |
apc999
force-pushed
the
branch-1.7-smallfix3
branch
from
661cc8f
to
85d8dda
Compare
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
|
Automated checks report:
All checks passed! |
|
@gpang PTAL |
gpang
approved these changes
Mar 6, 2018
| @@ -1504,7 +1504,7 @@ private void deleteFromEntry(DeleteFileEntry entry) { | |||
| failedToDelete = !ufsDeleter.delete(alluxioUriToDel, delInode); | |||
| } | |||
| } catch (InvalidPathException e) { | |||
| LOG.warn(e.getMessage()); | |||
| LOG.warn("Failed to delete path from UFS: {}", e.getMessage()); | |||
There was a problem hiding this comment.
Will e.getMessage() already include the UFS path?
There was a problem hiding this comment.
This exception is thrown when ufsDeleter failed to resolve mount table as the alluxio URL is invalid.
thus, it is about alluxio URL which will be included in exception message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging messages from
LOG.warn(e.getMessage());will not be able to locate.