Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add address in exception message when binding port for web server fails #9015

Merged
merged 1 commit into from May 9, 2019
Merged

Add address in exception message when binding port for web server fails #9015

merged 1 commit into from May 9, 2019

Conversation

apc999
Copy link
Contributor

@apc999 apc999 commented May 7, 2019

No port is given in the exception message if the port to bind is taken

image

@alluxio-bot
Copy link
Contributor

Automated checks report:

  • Commits associated with Github account: PASS
  • PR title follows the conventions: FAIL
    • The title of the PR does not pass all the checks. Please fix the following issues:
      • Title is too long (77 characters). Must be at most 72 characters.

Some checks failed. Please fix the reported issues and reply 'alluxio-bot, check this please' to re-run checks.

@apc999 apc999 changed the title Put address information in exception when failing to bind port for web server Add address in exception message when binding port for web server fails May 7, 2019
@alluxio-bot
Copy link
Contributor

Automated checks report:

  • Commits associated with Github account: PASS
  • PR title follows the conventions: PASS

All checks passed!

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3406/
Test PASSed.

@apc999 apc999 requested a review from bf8086 May 8, 2019 20:51
bf8086
bf8086 approved these changes May 8, 2019
View reviewed changes
Copy link
Contributor

@bf8086 bf8086 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the improvement!

@apc999
Copy link
Contributor Author

apc999 commented May 9, 2019

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit fd1ba3b into Alluxio:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bf8086 bf8086 bf8086 approved these changes

Assignees

@madanadit madanadit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@apc999 @alluxio-bot @AmplabJenkins @bf8086 @madanadit