Fix bugs related to the journal recovering from a UFS failure #9723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Automated checks report:
Some checks failed. Please fix the reported issues and reply 'alluxio-bot, check this please' to re-run checks. |
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
|
Automated checks report:
All checks passed! |
|
alluxio-bot, merge this please. |
calvinjia
added a commit
to calvinjia/tachyon
that referenced
this pull request
Aug 14, 2019
Fixes Alluxio#9722 Fixes several edge cases in journal recovery. 1. If we fail to flush to the journal, do not try to recover, instead flag the stream as needsRecovery and handle the recovery on next operation 2. When recovering, make sure there is a previous journal entry 3. When recovering, create a new log file starting with the latest committed journal entry (instead of our current one) 4. When recovering, fail if the latest journal entry recovered from our buffer is not equal to our expected next sequence number - 1 5. When recovering, do not consider incomplete logs when inferring the last persisted sequence number from the file name (it will be INTEGER_MIN) pr-link: Alluxio#9723 change-id: cid-63623a4e96d91f9619605dd9cad1b7da7679ac9c
calvinjia
added a commit
to calvinjia/tachyon
that referenced
this pull request
Aug 14, 2019
Fixes Alluxio#9722 Fixes several edge cases in journal recovery. 1. If we fail to flush to the journal, do not try to recover, instead flag the stream as needsRecovery and handle the recovery on next operation 2. When recovering, make sure there is a previous journal entry 3. When recovering, create a new log file starting with the latest committed journal entry (instead of our current one) 4. When recovering, fail if the latest journal entry recovered from our buffer is not equal to our expected next sequence number - 1 5. When recovering, do not consider incomplete logs when inferring the last persisted sequence number from the file name (it will be INTEGER_MIN) pr-link: Alluxio#9723 change-id: cid-63623a4e96d91f9619605dd9cad1b7da7679ac9c
jiacheliu3
pushed a commit
to jiacheliu3/alluxio
that referenced
this pull request
Nov 12, 2019
Fixes Alluxio#9722 Fixes several edge cases in journal recovery. 1. If we fail to flush to the journal, do not try to recover, instead flag the stream as needsRecovery and handle the recovery on next operation 2. When recovering, make sure there is a previous journal entry 3. When recovering, create a new log file starting with the latest committed journal entry (instead of our current one) 4. When recovering, fail if the latest journal entry recovered from our buffer is not equal to our expected next sequence number - 1 5. When recovering, do not consider incomplete logs when inferring the last persisted sequence number from the file name (it will be INTEGER_MIN) pr-link: Alluxio#9723 change-id: cid-63623a4e96d91f9619605dd9cad1b7da7679ac9c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9722
Fixes several edge cases in journal recovery.