Fix CSI and add multi mount #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ssz1997
commented
Oct 20, 2023
ssz1997
commented
- Use default /mnt/alluxio/fuse on host machine for alluxio mount point instead of staging path provided by CSI, which for unknown reason doesn't work.
- Add multi mount check for fuse template
ssz1997
commented
Oct 20, 2023
| @@ -36,11 +36,6 @@ type controllerServer struct { | |||
| func (cs *controllerServer) CreateVolume(ctx context.Context, req *csi.CreateVolumeRequest) (*csi.CreateVolumeResponse, error) { | |||
| volumeID := sanitizeVolumeID(req.GetName()) | |||
|
|
|||
| if err := cs.Driver.ValidateControllerServiceRequest(csi.ControllerServiceCapability_RPC_CREATE_DELETE_VOLUME); err != nil { | |||
There was a problem hiding this comment.
This check is not needed
| @@ -16,8 +16,6 @@ kind: PersistentVolumeClaim | |||
| metadata: | |||
| name: {{ $fullName }}-alluxio-csi-fuse-pvc | |||
| spec: | |||
| accessModes: | |||
| - ReadWriteOnce | |||
There was a problem hiding this comment.
Lift the restriction
| @@ -119,9 +119,6 @@ spec: | |||
| - until nslookup {{ $fullName }}-master-0; | |||
| do sleep 2; | |||
| done | |||
| volumeMounts: | |||
There was a problem hiding this comment.
Unnecessary volumeMount.
Kai-Zhang
approved these changes
Oct 25, 2023
|
Ask a question |
|
@jayxie8 The initContainer of the fuse pod would try to create the staging path if it doesn't exist, but then the actual container is not able to find that path. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.