Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AssetLoader PropertyMap and Text should not be cached #977

Closed
AlmasB opened this issue Mar 2, 2021 · 2 comments
Closed

AssetLoader PropertyMap and Text should not be cached #977

AlmasB opened this issue Mar 2, 2021 · 2 comments
Assignees
@AlmasB
Labels
type:bug Doesn't behave according to specification
Milestone
21

Comments

@AlmasB
Copy link
Owner

AlmasB commented Mar 2, 2021 •
edited

Instead, a new copy should be returned

Also check List<String> for text
@AlmasB AlmasB added the type:bug Doesn't behave according to specification label Mar 2, 2021
@AlmasB AlmasB self-assigned this Mar 2, 2021
@AlmasB AlmasB changed the title AssetLoader PropertyMap should not be cached AssetLoader PropertyMap and Text should not be cached Feb 26, 2023
@AlmasB AlmasB added this to the 21 milestone Feb 26, 2023
AlmasB added a commit that referenced this issue Feb 28, 2023
@AlmasB
fix: original asset objects are now cast during first load to avoid l…
6ba4715 
…eaking originals where we shouldnt, #977
@AlmasB
Copy link
Owner Author

AlmasB commented Feb 28, 2023

@chengenzhao once the build is complete, please can you test that List<String> that is returned during the first and second calls do not affect each other if modified, as per #1233

@chengenzhao
Copy link
Contributor

@chengenzhao once the build is complete, please can you test that List<String> that is returned during the first and second calls do not affect each other if modified, as per #1233

it works
cheers
thx

@AlmasB AlmasB closed this as completed in 901da1b Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlmasB AlmasB

Labels
type:bug Doesn't behave according to specification
Projects
None yet
Milestone
21
Development

No branches or pull requests
2 participants
@AlmasB @chengenzhao