fix(repositories): add lean() to find operations

without the lean() rest operations on returned object do not work as expected (lean returns the object without mongoose properties)
AlmogVC · Dec 21, 2019 · c248702 · c248702
1 parent 3f30a66
commit c248702
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 4 deletions.
diff --git a/src/service/service.repository.ts b/src/service/service.repository.ts
@@ -3,7 +3,9 @@ import ServiceModel from './service.model';
 
 export default class ServiceRepository {
     public static getOne(serviceFilter: Partial<IService>) {
-        return ServiceModel.findOne(serviceFilter).exec();
+        return ServiceModel.findOne(serviceFilter)
+            .lean()
+            .exec();
     }
 
     public static create(service: IService) {
@@ -15,6 +17,12 @@ export default class ServiceRepository {
         delete updatedService.createdAt;
         delete updatedService.id;
 
-        return ServiceModel.findOneAndUpdate({ name }, updatedService, { new: true });
+        return ServiceModel.findOneAndUpdate({ name }, updatedService, { new: true }).lean();
+    }
+
+    public static getAll() {
+        return ServiceModel.find({})
+            .lean()
+            .exec();
     }
 }
diff --git a/src/serviceHost/serviceHost.repository.ts b/src/serviceHost/serviceHost.repository.ts
@@ -7,10 +7,22 @@ export default class ServiceHostRepository {
     }
 
     public static updateLastAliveDate(service: string, hostname: string) {
-        return ServiceHostModel.findOneAndUpdate({ service, hostname }, { lastAliveDate: new Date() }, { new: true });
+        return ServiceHostModel.findOneAndUpdate(
+            { service, hostname },
+            { lastAliveDate: new Date() },
+            { new: true },
+        ).lean();
     }
 
     public static getOne(service: string, hostname: string) {
-        return ServiceHostModel.findOne({ service, hostname });
+        return ServiceHostModel.findOne({ service, hostname })
+            .lean()
+            .exec();
+    }
+
+    public static getMany(serviceHostFiler: Partial<IServiceHost>) {
+        return ServiceHostModel.find(serviceHostFiler)
+            .lean()
+            .exec();
     }
 }