-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.20.1] tag inheritance #57
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements tag inheritance. Preferred items will be able to inherit item and block tags from the unified items.
This allows obtaining tags from unified items that are required for gameplay mechanics. A good example would be beacon payment items or mods that use block tags for specifying valid blocks for multiblock structures.
The feature is config-controlled. By default, it does nothing. Two new config options will be populated automatically. This will not break existing configs.
Implementation notes
TagReloadHandler
in order to populate the tag maps that are dropped after the processTagMap
was abstracted and generified in order to support blocks as wellTagMap
creation no longer uses theTagManager
and is directly created with the raw tags received from theTagLoader
TagManagerMixin
is no longer requiredTagReloadHandler#resolveRelations
will work on a filtered tag map meaning all tags, that should allow inheriting from, need to be in the unification tagsAlmostUnifiedRuntime
are rebuilt in order to reflect changes by inheritanceExample
A really cursed example just to show the functionality. Keep in mind that at least two different namespaces are required or the items won't be unified.