Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indent and implement dpu health check through pub sub #176

Closed
wants to merge 1 commit into from

Conversation

tapishr
Copy link
Member

@tapishr tapishr commented May 21, 2024

Please check the action items covered in the PR -

  • Build is running
  • Eventing is functional and tested
  • Unit or integration tests added and running
  • Manual QA

Corresponding vibinex-server PR - vibinex/vibinex-server#353

@tapishr tapishr self-assigned this May 21, 2024
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

coderabbitai bot commented May 21, 2024

Walkthrough

The recent changes in the project involve enhancements to the vibi-dpu module, specifically within the pubsub/listener.rs file. Key updates include the addition of a get_client function in the reqwest_client module, the importation of the env module, and the implementation of a health_check function designed to send health check information to Vibinex.

Changes

File Path Change Summary
vibi-dpu/src/pubsub/listener.rs Added get_client function in reqwest_client module.
vibi-dpu/src/pubsub/listener.rs Imported env module.
vibi-dpu/src/pubsub/listener.rs Added health_check function to send health check info to Vibinex.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 44a0108 and 81c0a67.
Files selected for processing (1)
  • vibi-dpu/src/pubsub/listener.rs (3 hunks)
Additional comments not posted (2)
vibi-dpu/src/pubsub/listener.rs (2)

2-2: Approved the addition of reqwest_client::get_client and std::env imports as they are necessary for the new functionalities introduced in this PR.

Also applies to: 19-19


65-68: The integration of the health_check function within the process_message function is correctly implemented.

vibi-dpu/src/pubsub/listener.rs Show resolved Hide resolved
_ => {
log::error!("[process_message] Message type not found for message : {:?}", attributes);
}
};
}

async fn health_check() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW LOGAF: Can we put this function somewhere else? listeners.rs has grown quite large.

@tapishr
Copy link
Member Author

tapishr commented Jun 14, 2024

Implemented here - #181
Closing this

@tapishr tapishr closed this Jun 14, 2024
@tapishr tapishr deleted the tr/dpuLiveness branch June 14, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants