-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix indent and implement dpu health check through pub sub #176
Conversation
Quality Gate passedIssues Measures |
WalkthroughThe recent changes in the project involve enhancements to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- vibi-dpu/src/pubsub/listener.rs (3 hunks)
Additional comments not posted (2)
vibi-dpu/src/pubsub/listener.rs (2)
2-2
: Approved the addition ofreqwest_client::get_client
andstd::env
imports as they are necessary for the new functionalities introduced in this PR.Also applies to: 19-19
65-68
: The integration of thehealth_check
function within theprocess_message
function is correctly implemented.
_ => { | ||
log::error!("[process_message] Message type not found for message : {:?}", attributes); | ||
} | ||
}; | ||
} | ||
|
||
async fn health_check() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOW LOGAF: Can we put this function somewhere else? listeners.rs
has grown quite large.
Implemented here - #181 |
Please check the action items covered in the PR -
Corresponding vibinex-server PR - vibinex/vibinex-server#353