perf(main-thread): Optimise subscribers for notification speed

Alorel · Sep 27, 2020 · ba142d6 · ba142d6
1 parent 6f9fc43
commit ba142d6
Showing 1 changed file with 10 additions and 12 deletions.
diff --git a/projects/core/main-thread/lib/wrapped-store/createSubscribers.ts b/projects/core/main-thread/lib/wrapped-store/createSubscribers.ts
@@ -8,25 +8,23 @@ type Subscribers<S, A extends Action> = [
 
 /** @internal */
 export function createSubscribers<S, A extends Action>(): Subscribers<S, A> {
-  const subscribers = new Set<SubscribersFn<S, A>>();
+  const subscribers: Array<SubscribersFn<S, A>> = [];
 
   return [
-
-    // subscribe
-    listener => {
-      subscribers.add(listener);
+    function subscribe(listener) {
+      !subscribers.includes(listener) && subscribers.push(listener);
 
       return () => {
-        subscribers.delete(listener);
+        const idx = subscribers.indexOf(listener);
+        if (idx !== -1) {
+          subscribers.splice(idx, 1);
+        }
       };
     },
 
-    // Notify
-    (action, newState, oldState) => {
-      if (subscribers.size) {
-        for (const s of subscribers) {
-          s(action, newState, oldState);
-        }
+    function notifySubscribers(action, newState, oldState) {
+      for (let i = 0; i < subscribers.length; i++) {
+        subscribers[i](action, newState, oldState);
       }
     }
   ];