Fixes two memory leaks, which caused the scraper to crash after a while.... #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le. I believe this fixes #180. Fixes #352 (duplicate). Fixes #362 (duplicate). The destructor for AsyncHandle needs to be virtual as its subclasses are allocated dynamically. I believe this caused the ImageDownloadHandle and its related resources (such as the HttpReq and its contents) not to be freed correctly.
Aloshi
added a commit
that referenced
this pull request
Feb 10, 2015
Fixes two memory leaks, which caused the scraper to crash after a while....
|
Oh man, I never even thought about the destructor. I'm surprised I never got a compiler warning about this. Thanks so much! |
|
No worries! Thanks for the awesome software. Yeah, I would expect compilers to warn about this too. Perhaps the warning level is too low for this to show up? I tried adding -Wall to the compiler flags, and it gave me lots of warnings - not sure if this was included though! |
mmatyas
pushed a commit
to mmatyas/EmulationStation
that referenced
this pull request
Mar 28, 2018
Limiting Last Played view to the last 50 games you played
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... I believe this fixes #180.
Fixes #352 (duplicate).
Fixes #362 (duplicate).
The destructor for AsyncHandle needs to be virtual as its subclasses are
allocated dynamically. I believe this caused the ImageDownloadHandle and its
related resources (such as the HttpReq and its contents) not to be freed
correctly.