New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
移除个人依赖 #81
移除个人依赖 #81
Conversation
Signed-off-by: fzxiao233 <fzxiao@outlook.com>
Signed-off-by: fzxiao233 <fzxiao@outlook.com>
Signed-off-by: fzxiao233 <fzxiao@outlook.com>
Signed-off-by: fzxiao233 <fzxiao@outlook.com>
Signed-off-by: fzxiao233 <fzxiao@outlook.com>
time.Sleep(4 * time.Second) // wait to ensure the config is fully written | ||
ret, err := config.ReloadConfig() | ||
if ret { | ||
if err == nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid deeply nested control flow statements.
} | ||
|
||
func ExecShellEx(entry *log.Entry, redirect bool, name string, arg ...string) (string, string) { | ||
func ExecShell(name string, arg ...string) string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported function ExecShell should have comment or be unexported
Signed-off-by: fzxiao233 <fzxiao@outlook.com>
Code Climate has analyzed commit 4add067 and detected 5 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
No description provided.