Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.1 has a breaking change. #3

Closed
ljharb opened this issue Aug 31, 2018 · 2 comments
Closed

v1.0.1 has a breaking change. #3

ljharb opened this issue Aug 31, 2018 · 2 comments

Comments

@ljharb
Copy link

ljharb commented Aug 31, 2018

v1.0.0 depends on growl ^1.9, but v1.0.1 requires ^1.10.2.

Per tj/node-growl#79, > v1.10.0 has a breaking change, breaking on node < 4.

Would it be possible to publish a v1.0.2 that depends on growl =1.10.0?

ljharb added a commit to es-shims/es5-shim that referenced this issue Aug 31, 2018
jasmine-node v1.14+ depends on ~1.0.1 of jasmine-growl-reporter: mhevery/jasmine-node#433
jasmine-growl-reporter v1.0.1 depends on growl ^1.10.2: AlphaHydrae/jasmine-growl-reporter#3
growl v1.10.1+ has a breaking change: tj/node-growl#79
@AlphaHydrae
Copy link
Owner

Thanks. I wasn't aware of that. I published a v1.0.3 that depends on growl 1.10.0.

Since all node versions under 4 are past their EOL (probably node 4 as well), I also published a v2.0.0 that drops support for those, with up-to-date dependencies. Don't use that if you need node 0.12 or older.

@ljharb
Copy link
Author

ljharb commented Sep 7, 2018

Thanks!

v2 is fine, but note that just because a platform is EOL doesn't mean library authors must, or even should, drop support for it - EOL only means the platform authors have dropped support for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants