Fix alt art/anime version distinction

AlphaKretin · Dec 12, 2018 · c855c44 · c855c44
1 parent 4375e98
commit c855c44
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 5 deletions.
diff --git a/dist/class/Card.js b/dist/class/Card.js
diff --git a/lib/class/Card.ts b/lib/class/Card.ts
@@ -33,13 +33,20 @@ export class Card {
 
     get aliasIDs(): Promise<number[]> {
         return new Promise(async (resolve, reject) => {
+            const list = await cards.getRawCardList();
+            if (this.data.alias > 0) {
+                const alCard = list[this.data.alias];
+                if (alCard.data.ot !== this.data.ot) {
+                    resolve([this.id]);
+                }
+            }
             const baseCode = this.data.alias > 0 ? this.data.alias : this.id;
+            const baseCard = list[baseCode];
             const ids = [baseCode];
-            const list = await cards.getRawCardList();
             for (const id in list) {
                 if (list.hasOwnProperty(id)) {
                     const card = list[id];
-                    if (card && card.data.alias === baseCode) {
+                    if (card && card.data.alias === baseCode && card.data.ot === baseCard.data.ot) {
                         ids.push(parseInt(id, 10));
                     }
                 }

diff --git a/test/test.js b/test/test.js
@@ -124,11 +124,25 @@ describe("Testing alias check with name", function() {
 });
 describe("Testing alias check with alt art's code", function() {
     it("Should be [7852509, 7852510]", async function() {
-        const card = await index.getCard(7852510, "en");
+        const card = await index.getCard(7852510);
         const codes = await card.aliasIDs;
         expect(codes).to.deep.equal([7852509, 7852510]);
     });
 });
+describe("Testing alias check to exclude anime version", function() {
+    it("Should not include 513000134", async function() {
+        const card = await index.getCard(10000010);
+        const codes = await card.aliasIDs;
+        expect(codes).to.not.include(513000134);
+    });
+});
+describe("Testing alias check from anime version", function() {
+    it("Should be [513000134]", async function() {
+        const card = await index.getCard(513000134);
+        const codes = await card.aliasIDs;
+        expect(codes).to.deep.equal([513000134]);
+    });
+});
 describe("Testing image link", function() {
     it("Should be a string", async function() {
         const card = await index.getCard(7852510, "en");