Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TokenScript Management Page #1315

Closed
JamesSmartCell opened this issue Apr 14, 2020 · 6 comments · Fixed by #1344
Closed

Add TokenScript Management Page #1315

JamesSmartCell opened this issue Apr 14, 2020 · 6 comments · Fixed by #1344
Assignees

Comments

@JamesSmartCell
Copy link
Member

Page that matches iOS TokenScript management page which displays a list of Tokens that have a tokenscript.

Once we have a basic list of tokens we will expand on it to show warnings/errors and allow users to remove and otherwise manage scripts.

Add the page into the settings like this (@hboon can you please add iOS settings page screen shot with TokenScript management entry and another showing the script page):

TokenScript Management

You will be able to get a list of the scripts from assetDefinitionService using a method that traverses the assetDefinitions SparseArray/Mapping, making a list of holding contract tokens vs Filename. See method 'addContractAddresses' to see how to extract the holding contracts from each definition. Most scripts have only one holding contract token (eg Karma - 0x75cb...).

I'm thinking initially we want to see something like a list like this:

Script Name                 Filename                        
   - token address

eg

Car Ownership Token                 karma.canonicalized.xml (small font)
0x75cb...  (small font)

We may want to change this in future but for now this will be fine

@hboon
Copy link
Member

hboon commented Apr 14, 2020

@JamesSmartCell are you referring to these 2 screens?

TokenScript overrides Console

The Console screen was initially added to help with debugging. I was thinking it can log all kinds of errors. But never had the chance to go further with it.

@JamesSmartCell
Copy link
Member Author

Yes, thankyou. I had exactly the same thought, we can add some additional debugging information for developers in here, based on feedback from @James-Sangalli's interviews with developers trying to use TS, it should be very useful.

@JamesSmartCell
Copy link
Member Author

What is the 'Console' screen? Is it related to the Management screen or does it just display all the TS errors like 'Console' JS view in the browser?

@hboon
Copy link
Member

hboon commented Apr 15, 2020

Related because it displays validation errors and when two or more files are in conflict. I was hoping it can display additional errors and messages that help TokenScript authors but that isn’t relevant to users. Console output is a good candidate too.

@ChintanRathod
Copy link
Contributor

@JamesSmartCell Could you please close this ticket as PR is merged.

@JamesSmartCell
Copy link
Member Author

Completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants