Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Deeplink issues reported on Android Developer portal #2940

Merged
merged 1 commit into from Nov 15, 2022

Conversation

JamesSmartCell
Copy link
Member

@JamesSmartCell JamesSmartCell commented Nov 14, 2022

  • Fixes two issues reported on Android Developer portal:

image

image

May fix all three reported issues, as two may be caused by the signature not being correct.

May close #2938

@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for alpha-wallet-android:

User Total reviews Time to review Total comments
seabornlee
🥇
12
▀▀▀▀
3h 31m
10
▀▀▀▀▀▀▀▀
JamesSmartCell
🥈
10
▀▀▀
1d 41m
▀▀▀▀
1
justindg
🥉
8
▀▀▀
1d 5h 2m
▀▀▀▀▀
1

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Base: 7.62% // Head: 7.62% // No change to project coverage 👍

Coverage data is based on head (d1715d1) compared to base (ce2b794).
Patch has no changes to coverable lines.

❗ Current head d1715d1 differs from pull request most recent head 3d64558. Consider uploading reports for the commit 3d64558 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##             master   #2940   +/-   ##
========================================
  Coverage      7.62%   7.62%           
  Complexity      836     836           
========================================
  Files           612     612           
  Lines         41863   41863           
  Branches       4226    4226           
========================================
  Hits           3194    3194           
  Misses        38395   38395           
  Partials        274     274           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seabornlee seabornlee merged commit 7784baa into master Nov 15, 2022
@seabornlee seabornlee deleted the fix-deeplink-issues branch November 15, 2022 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PlayStore DeepLink Issue
2 participants