Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make queueForRealmStore as class property #5343 #5344

Merged
merged 1 commit into from Sep 12, 2022
Merged

make queueForRealmStore as class property #5343 #5344

merged 1 commit into from Sep 12, 2022

Conversation

oa-s
Copy link
Contributor

@oa-s oa-s commented Sep 12, 2022

Closes #5343

@oa-s oa-s requested a review from hboon September 12, 2022 12:40
@oa-s oa-s merged commit d6b5661 into AlphaWallet:master Sep 12, 2022
@oa-s oa-s deleted the #5343 branch September 12, 2022 12:54
hboon
hboon reviewed Sep 12, 2022
View reviewed changes
modules/AlphaWalletFoundation/AlphaWalletFoundation/Types/RealmStore.swift
@@ -63,7 +62,7 @@ open class RealmStore {
extension RealmStore {
public static var shared: RealmStore = RealmStore(realm: Realm.shared())

public static func storage(for wallet: Wallet) -> RealmStore {
public class func storage(for wallet: Wallet) -> RealmStore {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oa-s Why does this help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hboon hboon hboon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make queueForRealmStore as class property
2 participants
@oa-s @hboon