Https connections on weekend main branch #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed sclean clean status build check down up ip postgre from re rule, created a phony rule for that
sc00bid00
reviewed
Nov 13, 2023
There was a problem hiding this comment.
user.dot vs auth.dto both necessary? shouldn't we have only one?
sc00bid00
reviewed
Nov 13, 2023
There was a problem hiding this comment.
cool stuff here would be great to review together and learn from it
Cancelled comments assuming these have been forgotten
sc00bid00
reviewed
Nov 13, 2023
There was a problem hiding this comment.
removed comments see commit comment
sc00bid00
reviewed
Nov 13, 2023
sc00bid00
approved these changes
Nov 13, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.