replace Ascent's blueprint read with conduit read #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cyrush looks like the failures are all the same tests. Below, you'll find the output and baseline images. There's definitely slight differences. Should I investigate or chalk it up to a more robust read method and update the baseline images? Failing Test 51: dray_redistribute.redistribute new output: Failing Test 56: t_dray_mpi_volume_render new output: |
|
Let's re-baseline. I am a bit surprised there are differences, but this is a better way to read the data. Also, we should rip out the old reading code in ascent and dray. |
|
@cyrush I think I got everything. Look good? |
cyrush
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace relay_blueprint_mesh_read with conduit::relay::(mpi::)io::blueprint::load_mesh