Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic Slice using entropy #1066

Merged
merged 13 commits into from
Jan 5, 2023
Merged

Automatic Slice using entropy #1066

merged 13 commits into from
Jan 5, 2023

Conversation

nicolemarsaglia
Copy link
Contributor

Users provide a normal, a field, and the number of levels. The levels specify the number of equally spaced slices in the direction of the normal that will be considered. The chosen slice is the one with the highest entropy.

Serial Unit Test
MPI Unit Test
Docs

@nicolemarsaglia
Copy link
Contributor Author

Just noticed the "squash and merge" option. That's handy.

Copy link
Member

@cyrush cyrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, can you add a short note to the changelog and then we should merge.

@nicolemarsaglia
Copy link
Contributor Author

Looks awesome, can you add a short note to the changelog and then we should merge.

Sounds good! Ahh the changelog, I knew I forgot something!

@nicolemarsaglia nicolemarsaglia merged commit f425bfd into develop Jan 5, 2023
@nicolemarsaglia nicolemarsaglia deleted the task/slice_entropy branch January 5, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants