Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spatial options to thresh and cyl option to clip #1281

Merged
merged 15 commits into from May 11, 2024

Conversation

cyrush
Copy link
Member

@cyrush cyrush commented Apr 30, 2024

No description provided.

@cyrush
Copy link
Member Author

cyrush commented Apr 30, 2024

Wiring entity extraction logic to threshold filter to expand threshold subsetting with spatial options.

First attempt:

file: /Users/harrison37/Work/github/alpine-dav/ascent_co2/ascent/src/libs/ascent/runtimes/ascent_main_runtime.cpp
line: 2133
message: 
Execution failed with vtkm: Could not find appropriate cast for cell set in CastAndCall.
CellSet: CellSetPermutation of: 
   CellSetSingleType: Type=12
   CellPointIds:
     Shapes: valueType=h storageType=N4vtkm4cont18StorageTagConstantE 6859 values occupying 6859 bytes [12 12 12 ... 12 12 12]
     Connectivity: valueType=i storageType=N4vtkm4cont15StorageTagBasicE 54872 values occupying 219488 bytes [0 1 21 ... 7979 7999 7998]
     Offsets: valueType=i storageType=N4vtkm4cont18StorageTagCountingE 6860 values occupying 27440 bytes [0 8 16 ... 54856 54864 54872]
   PointCellIds:
     Not Allocated
Permutation Array: 
valueType=i storageType=N4vtkm4cont15StorageTagBasicE 3839 values occupying 15356 bytes [121 122 123 ... 6735 6736 6737]
TypeList: N4vtkm4ListIJNS_4cont17CellSetStructuredILi2EEENS2_ILi3EEENS1_15CellSetExplicitINS1_15StorageTagBasicES6_S6_EENS1_17CellSetSingleTypeIS6_EEEEE

(Stack trace unavailable)

:-(

@cyrush
Copy link
Member Author

cyrush commented Apr 30, 2024

  * frame #0: 0x000000010563bf08 libvtkh_core.dylib`vtkm::cont::Error::Error(this=0x0000600003b06c40, message="Could not find appropriate cast for cell set in CastAndCall.\nCellSet: CellSetPermutation of: \n   CellSetSingleType: Type=12\n   CellPointIds:\n     Shapes: valueType=h storageType=N4vtkm4cont18StorageTagConstantE 6859 values occupying 6859 bytes [12 12 12 ... 12 12 12]\n     Connectivity: valueType=i storageType=N4vtkm4cont15StorageTagBasicE 54872 values occupying 219488 bytes [0 1 21 ... 7979 7999 7998]\n     Offsets: valueType=i storageType=N4vtkm4cont18StorageTagCountingE 6860 values occupying 27440 bytes [0 8 16 ... 54856 54864 54872]\n   PointCellIds:\n     Not Allocated\nPermutation Array: \nvalueType=i storageType=N4vtkm4cont15StorageTagBasicE 3839 values occupying 15356 bytes [121 122 123 ... 6735 6736 6737]\nTypeList: N4vtkm4ListIJNS_4cont17CellSetStructuredILi2EEENS2_ILi3EEENS1_15CellSetExplicitINS1_15StorageTagBasicES6_S6_EENS1_17CellSetSingleTypeIS6_EEEEE\n", is_device_independent=true) at Error.h:65:3
    frame #1: 0x0000000105954814 libvtkh_core.dylib`vtkm::cont::internal::ThrowCastAndCallException(vtkm::cont::UnknownCellSet const&, std::type_info const&) + 396
    frame #2: 0x0000000108143b60 libvtkh_filters.dylib`vtkm::filter::clean_grid::CleanGrid::DoExecute(vtkm::cont::DataSet const&) + 268
    frame #3: 0x00000001077f6de0 libvtkh_filters.dylib`vtkh::vtkmCleanGrid::Run(this=0x000000016fdfb900, input=0x000000016fdfb908, map_fields=FieldSelection @ 0x000000016fdfb890) at vtkmCleanGrid.cpp:27:25
    frame #4: 0x0000000107632fc0 libvtkh_filters.dylib`vtkh::CleanGrid::DoExecute(this=0x000000016fdfba08) at CleanGrid.cpp:46:28
    frame #5: 0x0000000107628744 libvtkh_filters.dylib`vtkh::Filter::Update(this=0x000000016fdfba08) at Filter.cpp:51:3
    frame #6: 0x0000000107719300 libvtkh_filters.dylib`vtkh::Threshold::DoExecute(this=0x000000016fdfc798) at Threshold.cpp:292:11
    frame #7: 0x0000000107628744 libvtkh_filters.dylib`vtkh::Filter::Update(this=0x000000016fdfc798) at Filter.cpp:51:3
    frame #8: 0x0000000101c74ba0 libascent.dylib`ascent::runtime::filters::VTKHThreshold::execute(this=0x0000600003024360) at ascent_runtime_vtkh_filters.cpp:1564:14

Clean grid filter is not setup to digest the output of the Geometry Extractor.

@cyrush cyrush changed the title Add spatial optoins to thresh and cyl option to clip Add spatial options to thresh and cyl option to clip May 1, 2024
@cyrush cyrush added this to the 0.9.3 milestone May 6, 2024
@cyrush
Copy link
Member Author

cyrush commented May 9, 2024

Green for test container that was updated, just need new containers for the rest of the cases.

TODO:

  • Add note about VTK-m patch needed

@cyrush cyrush merged commit 73258c5 into develop May 11, 2024
20 checks passed
@cyrush cyrush deleted the task/2024_04_thresh_and_clip_enh branch May 11, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant