Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better enforce the schemas in the api #137

Open
fretchen opened this issue Nov 5, 2023 · 2 comments
Open

Better enforce the schemas in the api #137

fretchen opened this issue Nov 5, 2023 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@fretchen
Copy link
Contributor

fretchen commented Nov 5, 2023

Is your feature request related to a problem? Please describe.
The schemas in the storage_provider can be enforced much better. Currently we only type hint to a dict for get_backend_dict, upload_status, get_status, get_result, backend_dict_to_qiskit

Describe the solution you'd like
We have plenty of pretty clear Schemes in the Schema file. In Alqor-UG/qlued#216 we have tested how we can be much more specific on those.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
This should really allow us to be cleaner on types and information that is send around.

@fretchen fretchen added the enhancement New feature or request label Nov 5, 2023
@fretchen fretchen added this to the v0.3 milestone Nov 5, 2023
@fretchen fretchen transferred this issue from Alqor-UG/qlued Jan 2, 2024
@fretchen
Copy link
Contributor Author

fretchen commented Jan 2, 2024

We should hence to:

  • upload_status
  • upload_job
  • get_job_content
  • get_status
  • update_in_database
  • get_result
  • backend_dict_to_qiskit
  • get_backend_dict
  • ExperimentDict
  • add_job
  • get_dict_from_list
  • check_json_dict
  • check_dimension
  • check_experiment

Let's see how far we can get with this...

@fretchen fretchen modified the milestones: v0.3, v0.4 Jan 4, 2024
@fretchen
Copy link
Contributor Author

Closed the issues with the status

This was referenced Jan 12, 2024
@fretchen fretchen modified the milestones: v0.4, v0.5 Jan 22, 2024
@fretchen fretchen removed this from the v0.5 milestone Feb 6, 2024
@fretchen fretchen added the help wanted Extra attention is needed label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant