Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper job typing #150

Closed
fretchen opened this issue Jan 12, 2024 · 2 comments
Closed

Proper job typing #150

fretchen opened this issue Jan 12, 2024 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@fretchen
Copy link
Contributor

To finish #137 we need to have clean types for the job. What would this actually be ? This object would most certainly be passed in

upload_job, get_job and add_job

@fretchen fretchen added this to the v0.4 milestone Jan 12, 2024
@fretchen fretchen modified the milestones: v0.4, v0.5 Jan 22, 2024
@fretchen fretchen removed this from the v0.5 milestone Feb 6, 2024
@fretchen
Copy link
Contributor Author

fretchen commented Feb 6, 2024

The main challenge remains that each varying number of keys.

So on some level it is a dict with keys

{"experiment_0": ExperimentDict,
...}

If we can type this roughly we are in good shape.

@fretchen fretchen added the help wanted Extra attention is needed label Feb 6, 2024
@fretchen
Copy link
Contributor Author

Given how many tests we are already running in check_json_dict it is really not clear that we need this anymore...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant