Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added features #4

Open
Rodrigap opened this issue Apr 11, 2018 · 1 comment
Open

Added features #4

Rodrigap opened this issue Apr 11, 2018 · 1 comment

Comments

@Rodrigap
Copy link

Rodrigap commented Apr 11, 2018

I love that you added some extra features to this! The removal of the playlist tracks from the search results, as well as the ability to search on enter, makes your app a lot more user friendly. There's a couple of minor bugs in the first new feature, like that the song is only returned to the search results when you delete the song from the playlist and perform another search. Also, when you perform another search, you can add duplicate songs to the playlist because you never actually check to make sure that the song doesn't exist in the playlist before adding it

Alrefai added a commit that referenced this issue Apr 11, 2018
@Alrefai
Copy link
Owner

Alrefai commented Apr 11, 2018

The removed song from playlist is pushed back to the end of the search results. I understand that this is probably not a good design choice. But it is not easy to return the song to its original location in search results. Also, I think that returning the song to top of the search results in not a good choice either.

I thought about hiding the the ' + ' sign when a song is added to playlist. However, this require more code alternation. Moving the song between lists was easier to implement. I will think about a better solutions later.

The bug that add duplicate songs to the playlist is fixed. See below commit:
470eb6d

Alrefai added a commit that referenced this issue Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants