Skip to content

Commit

Permalink
Update generate_link_requests task
Browse files Browse the repository at this point in the history
django-q has problems with saving link requests queryset
  • Loading branch information
Alschn committed Feb 4, 2024
1 parent 805c766 commit 85c7dcf
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions links/queue/tasks.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import logging

from django.db.models import Q, QuerySet
from django.db.models import Q

from accounts.models import User
from links.emails import send_link_requests_email_notifications
Expand All @@ -12,12 +12,13 @@
logger.setLevel(logging.DEBUG)


def generate_link_requests() -> QuerySet[LinkRequest]:
def generate_link_requests() -> list[int]:
users = User.objects.filter(is_active=True)
link_requests = [LinkRequest.objects.create(user=user) for user in users]
link_requests_ids = [link_request.id for link_request in link_requests]

link_requests_qs = LinkRequest.objects.filter(
id__in=[link_request.id for link_request in link_requests],
id__in=link_requests_ids,
).select_related('user').filter(
# todo: filter user settings (send_daily_link_request_email=True)
~Q(user__email__exact=''),
Expand All @@ -26,7 +27,7 @@ def generate_link_requests() -> QuerySet[LinkRequest]:

send_link_requests_email_notifications(link_requests_qs)

return link_requests_qs
return link_requests_ids


def gather_metadata_for_link(link: Link) -> dict:
Expand Down

0 comments on commit 85c7dcf

Please sign in to comment.