Change BlocklyToFeature to extend BlocklyToJava - Feature Mod element #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlsoSomeoneElse
requested changes
Mar 23, 2022
src/main/java/net/mcreator/blockly/feature/BlocklyToFeature.java
Outdated
Show resolved
Hide resolved
|
Looks good, thank you! |
AlsoSomeoneElse
pushed a commit
that referenced
this pull request
Aug 8, 2023
* Update ai_path_node_type.md * Update beacon_color_modifier.md * Update bind_gui.md * Update block_sound.md * Update bounding_box.md * Update creative_pick_item.md * Update drop_amount.md * Update drop_inventory_items.md * Update unbreakable.md * Update when_added.md * Update when_entity_walks_on.md * Fix outrageous errors in Simplified Chinese!! (#2) * fixed * Update display_condition.md * Update base_texture.md * Update overlay_target.md * Update rendering_priority.md * Update display_condition.md (#3) * command * common * dimension * enchantment * feature * entity * fluid * function * name * gui * item * item_extension * keybinding * loottable * musicdisc * overlay * painting * recipe * structure * villagertrades * Create custom_property_name.md (#7) add * add (#6) add new help tip!!!!!! * chinese translation fix and add some external link (#4) * fix * Update generation_shape.md * Update harvest_level.md * Update coverage_estimate.md * Update default_features.md * Update toughness.md * update zh_TW * amend biome * block * common * dimension * enchantment * entity * fluid * gui * item * painting * particle * recipe * Update category.md (#8) * plant * Update gen_height.md * Update is_bonemealable.md * Update gen_height.md * Update gen_height.md --------- Co-authored-by: Jin1358 <126249552+Jin1358@users.noreply.github.com> Co-authored-by: cdc <63762187+cdc12345@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I asked you here if it could use Blockly2Java instead of BlocklyToCode directly, you answered me you couldn't as you needed to execute something before the code execution.
I adapted a little bit (minor changes)
BlocklyToJavaand yourBlocklyToFeature, so we can avoid repetitive code (the exact purpose of my recent changes with Blockly).I did not add the
BlocklyEditorToolbar, but it may be interesting to have it, so templates can be used in the future when complex features will be possible.