Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScanHelper Moving NPE exception above RuntimeException #824

Merged
merged 6 commits into from Feb 10, 2019
Merged

ScanHelper Moving NPE exception above RuntimeException #824

merged 6 commits into from Feb 10, 2019

Conversation

kababu007
Copy link
Contributor

ScanHelper Moving NPE exception above RuntimeException

kababu007 and others added 3 commits February 7, 2019 12:28
@kababu007
ScanHelper.java NullPointerException Handling
6334c52 
Handle NullPointException that crashes the app while the app is in background and ScanHelper tries to Stop or Start the Scan in Background.
log text change
33bb9d9
updating the latest file
12296a6
@kababu007
Copy link
Contributor Author

ScanHelper Moving NPE exception above RuntimeException

davidgyoung
davidgyoung reviewed Feb 9, 2019
View reviewed changes
Copy link
Member

@davidgyoung davidgyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, kababu007. Can you please also add a line to the top of CHANGELOG.md as part of this pull request? Perhaps describe the change as "Fix intermittent crash caused by internal Android NPE"

@kababu007
Copy link
Contributor Author

Updated the changelog as below:

2019-02-09 (#636, kababu007)

  • Fix intermittent crash caused by internal Android NPE

@davidgyoung davidgyoung merged commit 69eda0d into AltBeacon:master Feb 10, 2019
@davidgyoung davidgyoung mentioned this pull request Mar 6, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidgyoung davidgyoung davidgyoung left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kababu007 @davidgyoung