Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conflict PR#4 & PR#6 #7

Closed
EddieLukeAtmey opened this issue Apr 5, 2019 · 1 comment
Closed

Conflict PR#4 & PR#6 #7

EddieLukeAtmey opened this issue Apr 5, 2019 · 1 comment

Comments

@EddieLukeAtmey
Copy link
Contributor

PR #4 is a reverse version of #6, which both a fix for issue #5. You either choose one, not both. Since you merged both, the issue raise again but with a different error:

"startScanningAltbeacons, stopScanningAltbeacons" not implemented

I suggest you using merge #6 instead or #4 since it only change implement, not headers @davidgyoung
I can't reopen #5 so I create #7 instead
@EddieLukeAtmey
Copy link
Contributor Author

Fixed in #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@EddieLukeAtmey