Identifier, Beacon and BeaconParser #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…toothDevice has been implemented)
|
Even with all the caveats, this is a great starting point! |
davidgyoung
added a commit
that referenced
this pull request
Mar 9, 2015
Identifier, Beacon and BeaconParser
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, I only could convert 3 classes. I tried to follow Microsoft convention so that when people use this classes will not feel writing Java but .Net like it should be.
Btw, since I only converted 3 class, Beacon class is not complete (because of distance calculator) and also I since NLog is a little bit different than Android Logger I needed to exchange thoughts on how LogManager should implemented or even do we need it.
I also added unit test so you can be sure code works on your test cases.
Also, I have created a multi-project structure but If you don't like it feel free to change or comment.