Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default DMARC entries are not syntactically correct #441

Closed
kienanstewart opened this issue Nov 13, 2020 · 2 comments
Closed

Default DMARC entries are not syntactically correct #441

kienanstewart opened this issue Nov 13, 2020 · 2 comments
Labels
debian/buster Bugs / PR Related to Debian Buster PR/to be tested

Comments

@kienanstewart
Copy link
Contributor

In AlternC 3.5.0rc1, the default DMARC entries are set to

p=none;pct=100;rua=%%ADMINMAIL%%;aspf=r;adkim=r

The rest of the DMARC entry, v=dmarc1 is added in m_mail::set_dns_dmarc

There are two problems with the created records:

  1. The value of the v tag is case senstive and must be DMARC1 instead of dmarc1
  2. The value of rua should have mailto: before the e-mail address

(https://tools.ietf.org/html/rfc7489

A correct (complete) entry might look like

v=DMARC1;p=none;pct=100;rua=mailto:%%ADMINMAIL%%;aspf=r;adkim=r

thanks,
Kienan

kienanstewart pushed a commit to Koumbit/AlternC that referenced this issue Nov 13, 2020
@kienanstewart
Copy link
Contributor Author

PR #442

@camlafit camlafit added debian/buster Bugs / PR Related to Debian Buster PR/to be tested labels Jun 16, 2021
@vincib vincib closed this as completed in 2e1fbd3 Jun 16, 2021
@vincib vincib reopened this Jun 16, 2021
@vincib
Copy link
Contributor

vincib commented Jun 16, 2021

This bug will need a php script to fix the existing values in alternc upgraded from 3.x or 3.5~rc

I propose the following way to do it :

  • change the global variable value if it's the stock one, don't change it if it has been changed by the admin
  • change all sub_domains entries that contains a rua=address by rua=mailto:address,

tobald pushed a commit to tobald/AlternC that referenced this issue Dec 15, 2021
tobald pushed a commit to tobald/AlternC that referenced this issue Dec 15, 2021
tobald pushed a commit to tobald/AlternC that referenced this issue Nov 30, 2022
hubide pushed a commit to Koumbit/AlternC that referenced this issue Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debian/buster Bugs / PR Related to Debian Buster PR/to be tested
Projects
None yet
Development

No branches or pull requests

3 participants