feat: lineage refactor #1212
Open
feat: lineage refactor #1212
+37,361
−10,575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
saravmajestic
commented
Jun 17, 2024
| @@ -173,14 +173,6 @@ export class LineagePanel implements WebviewViewProvider, Disposable { | |||
| return; | |||
| } | |||
|
|
|||
| if (command === "openURL") { | |||
There was a problem hiding this comment.
this is handled via altimateWebviewProvider
| window.addEventListener( | ||
| "message", | ||
| ( | ||
| event: MessageEvent<{ command: string; args: Record<string, unknown> }>, |
Check warning
Code scanning / CodeQL
Missing origin verification in `postMessage` handler Medium
| event: MessageEvent<{ command: string; args: Record<string, unknown> }>, | ||
| ) => { | ||
| if (!event.origin.startsWith("vscode-webview://")) { | ||
| panelLogger.debug("invalid message ", event); |
Check warning
Code scanning / CodeQL
Log injection Medium
…e-dbt-power-user into feat/lineage-v2
saravmajestic
commented
Jul 9, 2024
| @@ -188,17 +188,6 @@ export class QueryResultPanel extends AltimateWebviewProvider { | |||
| ); | |||
| } | |||
|
|
|||
| private async checkIfWebviewReady() { | |||
There was a problem hiding this comment.
moved to altimateWebviewProvider
* fix: names and types * WIP * WIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Problem
Extract lineage component for better maintainability
Solution
Screenshot/Demo
A picture is worth a thousand words. Please highlight the changes if applicable.
How to test
dbt.enableLineageV2as true in settings.jsonChecklist
README.mdupdated and added information about my change