fix: lineage state issues #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdiGajbhiye
force-pushed
the
fix-lineage-state-issues
branch
2 times, most recently
from
162a7e9
to
a3a571c
Compare
|
@AdiGajbhiye @suryaiyer95 can you add some details of the fixes added in this PR? |
WIP fix: indirect edge WIP
AdiGajbhiye
force-pushed
the
fix-lineage-state-issues
branch
from
a3a571c
to
f0b9715
Compare
|
@saravmajestic Can you review? |
saravmajestic
approved these changes
Jun 28, 2024
suryaiyer95
commented
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Problem
There are state issue when performing column level lineage.
First full expanding table lineage and performing column lineage on just that works correctly.
But first performing column lineage and then expanding table lineage, shows wrong type of edges(direct/indirect).
Solution
Move assigning edge type code from creation of new edges to merging of edges.
Screenshot/Demo
A picture is worth a thousand words. Please highlight the changes if applicable.
How to test
Checklist
README.mdupdated and added information about my change