feat: sql lineage #1218
feat: sql lineage #1218
Conversation
WIP WIP feat: added new sql lineage panel WIP WIP WIP WIP WIP feat: added sql lineage panel
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| setTheme, | ||
| }; | ||
|
|
||
| window.addEventListener("message", (event) => { |
Check warning
Code scanning / CodeQL
Missing origin verification in `postMessage` handler Medium
| @@ -461,3 +583,47 @@ export const ColumnNode: FunctionComponent<NodeProps> = ({ data }) => { | |||
| </div> | |||
| ); | |||
| }; | |||
|
|
|||
| const LIGHT_ICONS: Record<string, React.ReactNode> = { | |||
There was a problem hiding this comment.
each of these icons differ only by fill color. We can use currentColor property in fill and handle the colors using css with theme. This will avoid maintaining multiple svgs and these Light and dark icon objects
| selfConnecting: SelfConnectingEdge, | ||
| }; | ||
|
|
||
| type StaticLineageProps = { |
There was a problem hiding this comment.
why is this called staticlineage?
| details: Details; | ||
| }; | ||
|
|
||
| const StaticLineage: FunctionComponent<StaticLineageProps> = ({ |
There was a problem hiding this comment.
This looks like repeated code from existing lineage. Is it possible to refactor to use same code?
| @@ -473,6 +509,113 @@ const processColumnLineage = async ( | |||
| return { nodes, edges, collectColumns, newCurr, confidence, seeMoreLineage }; | |||
| }; | |||
|
|
|||
| export const staticProcessColumnLineage = async ( | |||
There was a problem hiding this comment.
possible to reuse parts of existing processColumnLineage code?
| private terminal: DBTTerminal, | ||
| ) { | ||
| this.disposables.push( | ||
| dbtProjectContainer.onManifestChanged((event) => |
There was a problem hiding this comment.
this and related code can be replaced by using queryManifestService
| @@ -433,17 +426,23 @@ $size: 1.2em; | |||
| } | |||
| } | |||
|
|
|||
| .code_editor_container { | |||
There was a problem hiding this comment.
these are not needed anymore?
| }; | ||
|
|
||
| window.addEventListener("message", (event) => { | ||
| console.log("static-lineage:message -> ", event.data); |
Check warning
Code scanning / CodeQL
Log injection Medium
|
@saravmajestic, the review comments will be addressed in a different PR. Merging PR to enable beta testing. |
WIP
WIP
feat: added new sql lineage panel
WIP
WIP
WIP
WIP
WIP
feat: added sql lineage panel
Overview
Problem
Describe the problem you are solving. Mention the ticket/issue if applicable.
Solution
Describe the implemented solution. Add external references if needed.
Screenshot/Demo
A picture is worth a thousand words. Please highlight the changes if applicable.
How to test
Checklist
README.mdupdated and added information about my change