feat: Query sharing s3 #974
Open
+95
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gaurpulkit
commented
Mar 8, 2024
gaurpulkit
commented
- Modifying the existing Query Result Sharing PR by using a pre-signed s3 url to send the data directly to the user's s3 server instead of storing the data in Altimate's database.
|
I think the point is to have both ways. We should offer the choice to the user to either use s3 bucket or use our saas. @anandgupta42: Can you confirm? |
| @@ -219,25 +219,53 @@ export class QueryResultPanel implements WebviewViewProvider { | |||
| window.withProgress( | |||
| { | |||
| location: ProgressLocation.Notification, | |||
| title: "Uploading data to Altimate backend", | |||
| title: "Generating Shareable URL", | |||
| cancellable: false, | ||
| }, | ||
| async () => { | ||
| try { | ||
| const result = await this.altimate.shareQueryResult(message); | ||
| if (result?.share_url) { | ||
| await env.clipboard.writeText(result.share_url); | ||
| if (result?.signed_url) { |
There was a problem hiding this comment.
try early returns for better readability. ex:
if (!result?.signed_url){
window.showErrorMessage("Error generating signed url");
}
window.showInformationMessage(
"Generated signed url. Uploading data...",
);
....
| result.signed_url, | ||
| message, | ||
| ); | ||
| if (uploadResponse.status === 200) { |
There was a problem hiding this comment.
Also http related stuff shouldn't leak into implementations.
| ok: boolean; | ||
| share_url: string; | ||
| }; | ||
| if (verifyData.ok) { |
saravmajestic
requested changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.