Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--rm or --drop should respect skip_tables and use drop table if exists instead of drop database if exists #663

Closed
Slach opened this issue May 26, 2023 Discussed in #662 · 2 comments
Assignees
Milestone

Comments

@Slach
Copy link
Collaborator

Slach commented May 26, 2023

Discussed in #662

Originally posted by samene May 26, 2023
We have a backup configured to skip a few tables

skip_tables:
  - npo.REF*
  - npo.INSERT_*

Then when we do a restore of this backup using --rm and --schema followed by --data we see that the existing tables REF* and INSERT_* are missing and all others are restored.

Is this expected behaviour?

@Slach Slach added this to the 2.4.0 milestone May 26, 2023
@Slach Slach self-assigned this May 26, 2023
@Slach
Copy link
Collaborator Author

Slach commented May 26, 2023

subscribe to #663 and watch progress

@Slach Slach changed the title --rm or --drop should respect skip_tables and use drop table if exits instead of drop database if exists --rm or --drop should respect skip_tables and use drop table if exists instead of drop database if exists Jun 7, 2023
@Slach
Copy link
Collaborator Author

Slach commented Aug 14, 2023

looks like #583 implementation also too strictl and need add corner case

@Slach Slach closed this as completed in 9c71a59 Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant