-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow setting chunk_size #874
Conversation
run following command to fix tests
|
thanks for contibuting do you have statistict about speedup improvement for your change? |
i just added the option to configure the |
the command you gave me resulted in:
|
@dermasmid
|
got this now:
|
sorry
and run
|
i ran it but didnt get a new file
|
great then let's run whole testsuite
|
ok. to avoid conflict with master i will merge your PR (all integration test passed) please be ready fix something, if memory usage will significant change |
Thanks. Once there's an updated release I'll be able to test it |
…#874, thanks @dermasmid Merge branch 'master' into v2.5 # Conflicts: # test/testflows/clickhouse_backup/tests/snapshots/cli.py.cli.snapshot
Is there an image with these changes in them, so I can test it? |
try |
while running a backup to gcs it seemed to be very slow to upload, setting the
chunk_size
might make it faster