Fix wrong restoration of Materialized views with view name starting with digits #942
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, If the materialized view names start with a digit and are enclosed in a backtick(`) during the view creation, the regex group capture for matching the TO database is missing. This further leads to the wrong restoration of materialized views, as the TO still points to the source database!
For example:- If we run the following restore command,
clickhouse-backup restore_remote --rm -m default:praveen <backup-name>
The resulting materialized view will be the following. As you can see, the TO is still pointing to the source DB name, i.e.,
default
instead ofpraveen
)The expected one:-