Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics fetches never timeout #154

Closed
kcking opened this issue Aug 22, 2019 · 3 comments · Fixed by #159
Closed

Metrics fetches never timeout #154

kcking opened this issue Aug 22, 2019 · 3 comments · Fixed by #159
Labels
enhancement New feature or request

Comments

@kcking
Copy link
Contributor

kcking commented Aug 22, 2019

Hello all.

We have found an issue in our cluster where the operator metric fetch loop can get stuck waiting for a DB Ping or Exec that will never time out. I believe this can be solved by using PingContext and ExecContext inside of clickhouse.go, and passing in a context.Context with a reasonable timeout -- maybe something like 10 seconds.

What do you folks think? Thanks for the awesome operator!

@sunsingerus
Copy link
Collaborator

sunsingerus commented Aug 22, 2019

Yes, sure we need to introduce some kind of timeout for SQL processor, which runs queries towards ClickHouse instances in Pods. So far this part (monitoring in general and SQL queries in particular) is done in simple and straightforward manner, mainly because there are plenty of other thing to look after, and in order to have monitoring "operational in general".

@sunsingerus sunsingerus added the enhancement New feature or request label Aug 22, 2019
@filimonov
Copy link
Member

@kcking sounds reasonable. can you prepare the PR with that change?

@kcking
Copy link
Contributor Author

kcking commented Sep 6, 2019

just added a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants