Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pods are restarted when new shards/replicas are added #666

Closed
xiedeyantu opened this issue Mar 5, 2021 · 3 comments
Closed

Pods are restarted when new shards/replicas are added #666

xiedeyantu opened this issue Mar 5, 2021 · 3 comments

Comments

@xiedeyantu
Copy link
Contributor

release 0.12.0 first improvement:
Pods are no longer restarted when new shards/replicas are added.
But it will be restarted until 0.13.5.
Because of some cluster scope label changes, pods are restarted.

clickhouse.altinity.com/chiScopeCycleOffset: "3"
clickhouse.altinity.com/chiScopeIndex: "3"
clickhouse.altinity.com/clusterScopeCycleOffset: "3"
clickhouse.altinity.com/clusterScopeIndex: "3"

Is there any way to fix this problem?

@alex-zaitsev
Copy link
Member

Hi @xiedeyantu, could you describe what you are doing in more detail? CHI would be helpful. It looks like you are using CircularReplication, but we do not understand how it can change the cycle index and offset for existing pods.

If there is still a problem, the proper fix would be to remove those labels completely, they are just for the reference.

@xiedeyantu
Copy link
Contributor Author

xiedeyantu commented Mar 9, 2021

Hi @xiedeyantu, could you describe what you are doing in more detail? CHI would be helpful. It looks like you are using CircularReplication, but we do not understand how it can change the cycle index and offset for existing pods.

If there is still a problem, the proper fix would be to remove those labels completely, they are just for the reference.

I have come up with a solution to this problem. The method is to patch the labels of STS first, and then update STS. I have submitted a pr #667, could you take a look at this pr?

@alex-zaitsev
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants