-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error parsing Gtid when values exceeds MAX INTEGER #193
Labels
bug
Something isn't working
Comments
my patch to use diff --git a/sink-connector/src/main/java/com/altinity/clickhouse/sink/connector/metadata/TableMetaDataWriter.java b/sink-connector/src/main/java/com/altinity/clickhouse/sink/connector/metadata/TableMetaDataWriter.java
index 21b0c38..44a7bcb 100644
--- a/sink-connector/src/main/java/com/altinity/clickhouse/sink/connector/metadata/TableMetaDataWriter.java
+++ b/sink-connector/src/main/java/com/altinity/clickhouse/sink/connector/metadata/TableMetaDataWriter.java
@@ -56,7 +56,7 @@ public class TableMetaDataWriter {
} else if (colName.equalsIgnoreCase(KafkaMetaData.SERVER_ID.getColumn())) {
ps.setLong(index, record.getServerId()) ;
} else if (colName.equalsIgnoreCase(KafkaMetaData.GTID.getColumn())) {
- ps.setInt(index, record.getGtid());
+ ps.setLong(index, record.getGtid());
} else if (colName.equalsIgnoreCase(KafkaMetaData.BINLOG_FILE.getColumn())) {
ps.setString(index, record.getFile());
} else if (colName.equalsIgnoreCase(KafkaMetaData.BINLOG_POSITION.getColumn())) {
diff --git a/sink-connector/src/main/java/com/altinity/clickhouse/sink/connector/model/BlockMetaData.java b/sink-connector/src/main/java/com/altinity/clickhouse/sink/connector/model/BlockMetaData.java
index bb19bef..4f646e1 100644
--- a/sink-connector/src/main/java/com/altinity/clickhouse/sink/connector/model/BlockMetaData.java
+++ b/sink-connector/src/main/java/com/altinity/clickhouse/sink/connector/model/BlockMetaData.java
@@ -63,7 +63,7 @@ public class BlockMetaData {
@Getter
@Setter
- int transactionId = -1;
+ long transactionId = -1;
@Getter
@Setter
@@ -90,7 +90,7 @@ public class BlockMetaData {
public void update(ClickHouseStruct record) {
- int gtId = record.getGtid();
+ long gtId = record.getGtid();
if (gtId != -1) {
if (gtId > this.transactionId) {
this.transactionId = gtId;
diff --git a/sink-connector/src/main/java/com/altinity/clickhouse/sink/connector/model/ClickHouseStruct.java b/sink-connector/src/main/java/com/altinity/clickhouse/sink/connector/model/ClickHouseStruct.java
index fe6af9b..0db522b 100644
--- a/sink-connector/src/main/java/com/altinity/clickhouse/sink/connector/model/ClickHouseStruct.java
+++ b/sink-connector/src/main/java/com/altinity/clickhouse/sink/connector/model/ClickHouseStruct.java
@@ -76,7 +76,7 @@ public class ClickHouseStruct {
@Getter
@Setter
- private int gtid = -1;
+ private long gtid = -1;
@Getter
@Setter
@@ -220,7 +220,7 @@ public class ClickHouseStruct {
if(fieldNames.contains(GTID) && source.get(GTID) != null && source.get(GTID) instanceof String) {
String[] gtidArray = ((String) source.get(GTID)).split(":");
if(gtidArray.length == 2) {
- this.setGtid(Integer.parseInt(gtidArray[1]));
+ this.setGtid(Long.parseLong(gtidArray[1]));
}
}
if(fieldNames.contains(LSN) && source.get(LSN) != null && source.get(LSN) instanceof Long) {
|
sergiyprykhodko
added a commit
to maklai-dev/clickhouse-sink-connector
that referenced
this issue
Oct 2, 2023
This was referenced Oct 2, 2023
Fixed in #346 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: