Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework docker-compose-mysql.yml example used in the quikcstart guide #404

Merged
merged 23 commits into from
Dec 13, 2023

Conversation

Selfeer
Copy link
Collaborator

@Selfeer Selfeer commented Dec 7, 2023

Rework the docker-compose-mysql.yml file used for a quickstart guide.

Updates:

  • Moved services used inside a main compose file into separate service files
  • For the Grafana, instead of building from a dockerfile that copies config files, we have a grafana service that instead mounts config files as volumes and uses grafana/grafana:latest image.


services:
clickhouse-sink-connector-lt:
image: ${CLICKHOUSE_SINK_CONNECTOR_IMAGE}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we update the quickstart.md with this new environment variable.

@Selfeer Selfeer merged commit 9860722 into develop Dec 13, 2023
3 of 5 checks passed
@Selfeer Selfeer deleted the rework-docker-compose-example branch December 13, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants