-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ddl parser bugs #450
Fix ddl parser bugs #450
Conversation
@bader-tayeb Thanks for your contribution. |
@subkanthi done a737dc1 |
@subkanthi anything else? |
Hi @bader-tayeb , there are some test failures, need to check if its related to the change. |
Hi @bader-tayeb , is there anyway u can resolve the conflicts? failing tests were fixed. |
a737dc1
to
de54a7d
Compare
hello @subkanthi I rebased it, but I am not sure how to re-run the tests. |
Two fixes here:
parseAlterTable
used to ignore new columns that were of type JSON or ENUM.enterAlterByAddCheckTableConstraint
would fail if we have a constraints with logical statements (e.g. "num > 1 and num > 2")