Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ddl parser bugs #450

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Conversation

bader-tayeb
Copy link
Contributor

Two fixes here:

  1. parseAlterTable used to ignore new columns that were of type JSON or ENUM.
  2. enterAlterByAddCheckTableConstraint would fail if we have a constraints with logical statements (e.g. "num > 1 and num > 2")

@subkanthi
Copy link
Collaborator

@bader-tayeb Thanks for your contribution.
Can you also please add the query to the Integration test in AddColumnIT, it will be a better test as it applies the DDL on MySQL and validates the result in ClickHouse.

@bader-tayeb
Copy link
Contributor Author

@subkanthi done a737dc1

@bader-tayeb
Copy link
Contributor Author

@subkanthi anything else?

@subkanthi
Copy link
Collaborator

@subkanthi anything else?

Hi @bader-tayeb , there are some test failures, need to check if its related to the change.

@subkanthi
Copy link
Collaborator

@subkanthi anything else?

Hi @bader-tayeb , there are some test failures, need to check if its related to the change.

@subkanthi anything else?

Hi @bader-tayeb , there are some test failures, need to check if its related to the change.

Hi @bader-tayeb , is there anyway u can resolve the conflicts? failing tests were fixed.

@bader-tayeb
Copy link
Contributor Author

@subkanthi anything else?

Hi @bader-tayeb , there are some test failures, need to check if its related to the change.

@subkanthi anything else?

Hi @bader-tayeb , there are some test failures, need to check if its related to the change.

Hi @bader-tayeb , is there anyway u can resolve the conflicts? failing tests were fixed.

hello @subkanthi I rebased it, but I am not sure how to re-run the tests.

@subkanthi subkanthi merged commit 30dc1b8 into Altinity:develop Feb 21, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants