Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed from ts_ms to debezium ts_ms for adding sequence numbers #569

Merged
merged 2 commits into from
May 6, 2024
Merged

Changed from ts_ms to debezium ts_ms for adding sequence numbers #569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9110da0
Changed from ts_ms to debezium ts_ms for adding sequence numbers
subkanthi May 6, 2024
686cfea
Removed initial seed logic for setting sequence number
subkanthi May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 7 additions & 14 deletions ...c/main/java/com/altinity/clickhouse/debezium/embedded/cdc/DebeziumChangeEventCapture.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,6 @@ public void setupDebeziumEventCapture(Properties props, DebeziumRecordParserServ
try {
DebeziumEngine.Builder<ChangeEvent<SourceRecord, SourceRecord>> changeEventBuilder = DebeziumEngine.create(Connect.class);
changeEventBuilder.using(props);
final boolean[] initialBootstrap = {true};
changeEventBuilder.notifying(new DebeziumEngine.ChangeConsumer<ChangeEvent<SourceRecord, SourceRecord>>() {
@Override
public void handleBatch(List<ChangeEvent<SourceRecord, SourceRecord>> list,
Expand All @@ -556,8 +555,7 @@ public void handleBatch(List<ChangeEvent<SourceRecord, SourceRecord>> list,
}
}
// Add sequence number.
addVersion(batch, initialBootstrap[0]);
initialBootstrap[0] = false;
addVersion(batch);


if(batch.size() > 0) {
Expand Down Expand Up @@ -759,36 +757,31 @@ private void appendToRecords(List<ClickHouseStruct> convertedRecords) {
* Function to add version to every record.
* @param chStructs
*/
public static void addVersion(List<ClickHouseStruct> chStructs, boolean initialSeed) {
public static void addVersion(List<ClickHouseStruct> chStructs) {

// Start the sequence from 1 million and increment for every record
// and reset the sequence back to 1 million in the next second
if(chStructs.isEmpty()) {
return;
}
long sequenceStartTime = chStructs.get(0).getTs_ms();
long sequenceStartTime = chStructs.get(0).getDebezium_ts_ms();
//long sequence = SEQUENCE_START;
if(initialSeed) {
// Add 500 million to the sequence
// sequence += 500000000;
// Add 000 to the debezium timestamp.
sequenceNumber = SEQUENCE_START_INITIAL;
}

for(ClickHouseStruct chStruct: chStructs) {
// Get the first ts_ms from chStruct
// Subsequent records add 1 to sequence.
// If its been more than a second from the first
// ts_ms then reset the sequence.
// Get diff in seconds
int diff = (int) (chStruct.getTs_ms() - sequenceStartTime) / 1000;
int diff = (int) (chStruct.getDebezium_ts_ms() - sequenceStartTime) / 1000;
if(diff > 1) {
sequenceNumber = SEQUENCE_START;
sequenceStartTime = chStruct.getTs_ms();
sequenceStartTime = chStruct.getDebezium_ts_ms();
} else {
sequenceNumber++;
}
// Pad the sequence number with 0s
chStruct.setSequenceNumber(chStruct.getTs_ms() * 1000000 + sequenceNumber);
chStruct.setSequenceNumber(chStruct.getDebezium_ts_ms() * 1000000 + sequenceNumber);
}
}
}
4 changes: 2 additions & 2 deletions ...st/java/com/altinity/clickhouse/debezium/embedded/cdc/DebeziumChangeEventCaptureTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,12 +97,12 @@ public void shouldAssignUniqueSequenceNumbersWithinSameSecond() throws Interrupt

// Make a list of ch1, ch2, ch3 and ch4
List<ClickHouseStruct> clickHouseStructs = Arrays.asList(ch1, ch2, ch3, ch4, ch5);
DebeziumChangeEventCapture.addVersion(clickHouseStructs, true);
DebeziumChangeEventCapture.addVersion(clickHouseStructs);

Thread.sleep(1000);
// Add ch5 and ch6
List<ClickHouseStruct> clickHouseStructs2 = Arrays.asList(ch5, ch6);
DebeziumChangeEventCapture.addVersion(clickHouseStructs2, false);
DebeziumChangeEventCapture.addVersion(clickHouseStructs2);

// Check if the sequence numbers are unique
assertTrue(clickHouseStructs.get(0).getSequenceNumber() < clickHouseStructs.get(1).getSequenceNumber());
Expand Down
Loading