Avoid printing error logs when there are no records in the queue #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o log4j, Added slf4j2 to log4j to route slf4j2 calls to log4j
Closed
….com:Altinity/clickhouse-sink-connector into 667-investigate-errors-regarding-empty-batch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the changes also for logging.
We include libraries that contain different logging implementation(java.util.logging(JUL) and slf4j).
Included log4j adapter for JUL so that all JUL logs are routed to log4j
Included Slf4j log4j implementation (version 2) so that slf4j logs are routed to log4j
closes: #578
closes: #642
closes: #667
closes: #666